This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix ordering of DS matchlists to match the Perl#3066
Merged
Conversation
The DS matchlist needs to be ordered by the set_number just like it was done in the Perl. There are clients that depend on that specific ordering, e.g. Traffic Portal which uses the first exampleURL to create the hostName field of an "add cert to DS" request.
rawlinp
added
bug
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
❤️ for tests |
rawlinp
added a commit
to rawlinp/trafficcontrol
that referenced
this pull request
Nov 29, 2018
The DS matchlist needs to be ordered by the set_number just like it was done in the Perl. There are clients that depend on that specific ordering, e.g. Traffic Portal which uses the first exampleURL to create the hostName field of an "add cert to DS" request. (cherry picked from commit 53e9e32)
17 tasks
dg4prez
pushed a commit
that referenced
this pull request
Nov 29, 2018
The DS matchlist needs to be ordered by the set_number just like it was done in the Perl. There are clients that depend on that specific ordering, e.g. Traffic Portal which uses the first exampleURL to create the hostName field of an "add cert to DS" request. (cherry picked from commit 53e9e32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The DS matchlist needs to be ordered by the set_number just like it was
done in the Perl. There are clients that depend on that specific
ordering. For example, Traffic Portal uses the first exampleURL to create
the hostName field of an "add cert to DS" request. Since the exampleURLs
are created from the DS's matchlist, this can cause the cert request to
contain an alias which makes ORT unhappy.
Which TC components are affected by this PR?
What is the best way to verify this PR?
Run the unit tests, make sure they pass.
Create a DSes of type HTTP and DNS and add HOST_REGEXP aliases to them. Verify that the
<routing_name>.<xml_id>.<cdn_domain>fqdn(s) are at the top of the list of the DS's example URLs.Check all that apply