This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix improper file slurping in Perl#3143
Merged
dangogh merged 1 commit intoapache:masterfrom Dec 18, 2018
Merged
Conversation
The proper way to enable slurp mode is by doing `local $/;`. When you do `undef $/` it is undefining the global `$/` input record separator which is bad and can cause a multitude of problems. Using the `local` version only nullifies the input record separator locally in order to enable slurp mode in that particular function rather than changing it globally.
rawlinp
added
bug
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
dangogh
approved these changes
Dec 18, 2018
jranson
added a commit
to jranson/trafficcontrol
that referenced
this pull request
Jan 25, 2019
Revert changes in vendor Fix syntax error in goose migration DELETE COLUMN should be DROP COLUMN. v4 - now identifies order-only diffs (apache#3121) Fixed a Python2 compatibility issue in the Traffic Control client (apache#3115) * Fixed an issue where Python3-specific syntax was used Fix implemented using pre-existing 'future' dependency - `future.utils.raise_from`. * Removed trailing whitespace and ANSI control characters I also took the opportunity to fix a couple of URLs in areas where the control characters got left in. Another PR will need to address the fact that those are all wrong since the overhaul Removed unnecessary http-parser dependency (apache#3126) Fix TO CRConfig tm.url to be fdqn, not uri Add Traffic Vault steps for Self Signed SSL (apache#3122) * TrafficVault update docs for Self Signed SSL lock TP dependency (apache#3132) Python client Package restructure (apache#3130) Restructures the Python Traffic Control client into a real package - without links . Also includes real documentation linking, real contact info for the package, and adds missing endpoint references/fixes old/deprecated/broken ones, removed a couple of duplicated endpoint methods and fixes some poorly-formatted reference labels in the API documentation. Updated documentation for the new Go db/admin binary (apache#3128) Also, fix some code-block syntax errors so that they actually show up in the documentation. Configuration file route generation script now works with restructured ATC client (apache#3142) Fix improper file slurping in Perl (apache#3143) The proper way to enable slurp mode is by doing `local $/;`. When you do `undef $/` it is undefining the global `$/` input record separator which is bad and can cause a multitude of problems. Using the `local` version only nullifies the input record separator locally in order to enable slurp mode in that particular function rather than changing it globally. Fix TO query for crconfig column rename (apache#3137) Fixes apache#3136 Add additional response code information in responder.go. (apache#3141) This would help with issue 3139. fix builder Dockerfiles (apache#3152) Added documentation guidelines (apache#3133) also fixed a label that was in conflict with said guidelines, provided cursor hints for abbreviations and removed a warning about building the docs with Python 3.7+ (related bug is now fixed). Added a configuration setting, 'DisableHTTP2'. The setting (apache#3149) is false by default but when set to 'true', the grove server will not negotiate and serve HTTP2. Added an explanation of the format and structure of API endpoint docs implemented proper text roles for RFC and mimetypes Fix method call due to false positive from `misspell`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The proper way to enable slurp mode is by doing
local $/;. When you doundef $/it is undefining the global$/input record separator whichis bad and can cause a multitude of problems. Using the
localversiononly nullifies the input record separator locally in order to enable
slurp mode in that particular function rather than changing it globally.
Which TC components are affected by this PR?
What is the best way to verify this PR?
Hit the
POST /api/$version/isos?stream=yesendpoint. This can be done in Traffic Portal, just make sure to set stream=yes in order to hit the changed code. I'm not sure how to really verifyparse_retention_period_in_secondssince I can't find anywhere in the code that actually uses that function. The GenDbDump change isn't really verifiable anymore since it's a UI endpoint, but this should cover our bases in case it is being used in some obscure way by a non-UI endpoint.Check all that apply