This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix Traffic Ops GET statuses to allow null descriptions#3148
Merged
rawlinp merged 3 commits intoapache:masterfrom Mar 4, 2019
Merged
Fix Traffic Ops GET statuses to allow null descriptions#3148rawlinp merged 3 commits intoapache:masterfrom
rawlinp merged 3 commits intoapache:masterfrom
Conversation
rob05c
added
bug
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
rawlinp
approved these changes
Mar 1, 2019
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
Code looks good, API tests pass, manual tests pass. Please rebase this so I can merge.
Allows creating a status with a null description. Necessary to create an API Test to get a status with a null desc.
rob05c
force-pushed
the
to-status-null-desc-fix
branch
from
c7b5cb5 to
5ed7a4c
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
zrhoffman
added a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Dec 6, 2021
zrhoffman
added a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Dec 6, 2021
4 tasks
ocket8888
pushed a commit
that referenced
this pull request
Dec 8, 2021
* Use latest module versions
rm go.mod
go mod init
go mod tidy
* Add license pointer for go.uber.org/atomic
* Remove null Status description workaround from #3148 now that jmoiron/sqlx#429 is merged
* Do not downgrade anything
go get github.com/basho/riak-go-client@5587c16e0b8b \
github.com/dgrijalva/jwt-go@5e25c22bd5d6 \
github.com/kylelemons/godebug@e693023230a4
go mod tidy
* Revendor dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Traffic Ops GET statuses to allow null descriptions
Includes API Tests.
Which TC components are affected by this PR?
What is the best way to verify this PR?
Run API tests. Create a status with a null description, and call
GET /statuses.Check all that apply