Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Comments

TP: sorts the results of GET /tenants to represent the hierarchy#3166

Merged
dangogh merged 1 commit intoapache:masterfrom
mitchell852:fix-tenants-ordering
Dec 28, 2018
Merged

TP: sorts the results of GET /tenants to represent the hierarchy#3166
dangogh merged 1 commit intoapache:masterfrom
mitchell852:fix-tenants-ordering

Conversation

@mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Dec 27, 2018

What does this PR do?

Fixes #3159

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other _________

What is the best way to verify this PR?

  1. Launch TP
  2. Navigate to https://tp.domain.com/#!/tenants
  3. Verify that the list of tenants represents the hierarchy. I.e.
root
root.1
root.1.1
root.1.2
root.2
root.2.1
root.2.2

Also edit a tenant, delivery service, origin or user and ensure that the Tenant dropdown is ordered properly

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR includes a database migration (ensure that migration sequence is correct)
  • This PR fixes a serious security flaw. Read more: www.apache.org/security

@mitchell852 mitchell852 added the Traffic Portal v1 related to Traffic Portal version 1 label Dec 27, 2018
@asfgit
Copy link
Contributor

asfgit commented Dec 27, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2990/
Test PASSed.

@dangogh dangogh self-assigned this Dec 28, 2018
@asfgit
Copy link
Contributor

asfgit commented Dec 28, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2992/
Test PASSed.

Copy link
Member

@dangogh dangogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in cdn-in-a-box:

  • added new tenant 2 levels down
  • edit and new: user, tenant, deliveryservice, origin all display the hierarchy properly

@dangogh dangogh merged commit 84903a8 into apache:master Dec 28, 2018
@mitchell852 mitchell852 deleted the fix-tenants-ordering branch July 15, 2019 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GET /api/tenants ordering changed from Perl to Go

3 participants