-
Notifications
You must be signed in to change notification settings - Fork 351
WIP Add Delivery Service Snapshots #3175
base: master
Are you sure you want to change the base?
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
09c1ac9 to
71417e0
Compare
|
Refer to this link for build results (access rights to CI server needed): |
71417e0 to
e835126
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
0871d72 to
ea7800c
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Currently not used for anything. Subsequent changesets will use to select rows for building the CRConfig.
Fixes CRConfig generation with DS Snapshots to return {}, like Perl.
The where query part was previously inside the last_updated sorting. It has to be outside, because the where filtering needs to happen after getting the latest snapshot row. For example, if a DS is changed to inactive, putting the where inside the 'where last_updated < snap order by last_updated' will make the latest inactive row be excluded, and the latest active row selected.
5e88f74 to
c4885a8
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
This should be added to the Self Service Change Integrity project because #2097 was closed in favor of it. |
WIP - Adds Delivery Service Snapshots.
Still WIP, needs work, but I thought I'd make it available for public comment.UPDATE 2019-11-14: I rebased to fix the conflicts, but haven't tested. Prior to the conflicts, this was AFAIK complete and working, but I still want to write a bunch of TO API Tests before removing the "WIP."
See https://cwiki.apache.org/confluence/display/TC/Traffic+Control++Self+Service+Proposal+for+Change+Integrity
This follows the plan, with one major exception: it creates new "_snapshot" tables, which are copied into on snapshot. This is because Perl touches many of these tables, and the Perl can't be easily fixed.
The idea is, if we want DS snapshots now, we can implement them much sooner, without rewriting all of Perl, with these "snapshot" tables. Then, when Perl finally goes away, we can simply create a database migration to rename the "snapshot" tables.
Specifically Includes
deliveryservices/{ds-name}/snapshotmonitoring.jsonalso builds on-the-fly from snapshot tablesupdate 2019-02-09
All concerns I'm aware of have been addressed. The only thing left is parity testing, to be sure everything behaves correctly.
update 2019-02-19
Need to add #3333
What does this PR do?
Which TC components are affected by this PR?
What is the best way to verify this PR?
Check all that apply