This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Records.config ds profile parameters#3279
Merged
Merged
Conversation
These changes allow you to put records.config parameters in to a DS profile and have them appear as remap overrides. This is similar to how cachekey works in the DS profile. If the file given is for records.config then options are generated for the remaps from the DS in this manner: @plugin=conf_remap.so @pparam=param_name=value This way you can do parameter overrides without having to use raw remap. The parameters are expected to match the existing usages of records.config parameters in the scheme of: CONFIG paramater_name INT/STRING/FLOAT value outside of this the parameter will be rejected
…ces in case for some strange reason thats a thing
Contributor
|
Can one of the admins verify this patch? |
dangogh
suggested changes
Jan 30, 2019
| } | ||
|
|
||
| #Add DS profile records.config entries as overrided ATS parameters | ||
| if ( defined( $remap->{'param'}->{'records.config'} ) ) { |
Member
There was a problem hiding this comment.
this repeats the above -- would it make sense to make it a sub?
Member
Author
There was a problem hiding this comment.
Between the build_remap and the mid_remap there is a lot of similar duplication. It might make sense to make it a sub but it also follows the existing code convention thats there to just leave it as is
We may also want to treat edge/mid differently in the future depending on how this gets used (though will probably completely change if/when DS profiles get removed or all the ATS config gets moved in to golang) if we want a way to differentiate parameters that may only apply to one
* Changed quote usage
dangogh
approved these changes
Jan 31, 2019
mitchell852
added
new feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #(issue_number)
Which TC components are affected by this PR?
What is the best way to verify this PR?
Add records.config parameters to a DS profile, make sure existing remaps stay the same
Check all that apply