Converts Edge/Mid header rewrite, regexremap, remaptext and tr request/response header text inputs to textareas

CHANGELOG.md

@@ -27,6 +27,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Snapshotting the CRConfig now deletes HTTPS certificates in Riak for delivery services which have been deleted in Traffic Ops.
 - Added a context menu in place of the "Actions" column from the following tables in Traffic Portal: cache group tables, CDN tables, delivery service tables, parameter tables, profile tables, server tables.
 - Traffic Portal standalone Dockerfile
+- In Traffic Portal, removes the need to specify line breaks using `__RETURN__` in delivery service edge/mid header rewrite rules, regex remap expressions, raw remap text and traffic router additional request/response headers.
 
 ### Changed
 - Traffic Router, added TLS certificate validation on certificates imported from Traffic Ops

docs/source/admin/traffic_ops/using.rst

@@ -432,9 +432,9 @@ The fields in the :term:`Delivery Service` view are:
 |                                            |                                                                                                                                                                        |
 |                                            | See :ref:`header-rewrite`. [1]_                                                                                                                                        |
 +--------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
-| Traffic Router Additional Response Headers | List of header name:value pairs separated by __RETURN__. Listed pairs will be included in all TR HTTP responses.                                                       |
+| Traffic Router Additional Response Headers | List of header name:value pairs. One name:value pair per line. Listed pairs will be included in all Traffic Router HTTP(S) responses.                                  |
 +--------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
-| Traffic Router Log Request Headers         | List of header keys separated by __RETURN__. Listed headers will be included in TR access log entries under the “rh=” token.                                           |
+| Traffic Router Log Request Headers         | List of header keys. One header key per line. Listed headers will be included in Traffic Router access log entries under the "rh=" token.                              |
 +--------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
 | Regex remap expression                     | Allows remapping of incoming requests URL using regex pattern matching to search/replace text.                                                                         |
 |                                            | See `ATS documentation on regex_remap  <https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/regex_remap.en.html>`_. [1]_                               |

traffic_ops/traffic_ops_golang/crconfig/deliveryservice.go

@@ -315,7 +315,8 @@ and d.active = true
 		ds.IP6RoutingEnabled = &ip6RoutingEnabled.Bool // No Valid check, false if null
 
 		if trResponseHeaders.Valid && trResponseHeaders.String != "" {
-			hdrs := strings.Split(trResponseHeaders.String, `__RETURN__`)
+			trResponseHeaders.String = strings.Replace(trResponseHeaders.String, "__RETURN__", "\n", -1)
+			hdrs := strings.Split(trResponseHeaders.String, "\n")
 			for _, hdr := range hdrs {
 				nameVal := strings.Split(hdr, `:`)
 				name := strings.TrimSpace(nameVal[0])
@@ -328,7 +329,8 @@ and d.active = true
 		}
 
 		if trRequestHeaders.Valid && trRequestHeaders.String != "" {
-			hdrs := strings.Split(trRequestHeaders.String, `__RETURN__`)
+			trRequestHeaders.String = strings.Replace(trRequestHeaders.String, "__RETURN__", "\n", -1)
+			hdrs := strings.Split(trRequestHeaders.String, "\n")
 			for _, hdr := range hdrs {
 				nameVal := strings.Split(hdr, `:`)
 				name := strings.TrimSpace(nameVal[0])

traffic_portal/app/src/common/modules/form/_form.scss

@@ -85,6 +85,10 @@ input[type="url"]:invalid ~ small.invalid-URL-error {
 	visibility: visible;
 }
 
+textarea.autosize:read-only {
+	overflow: hidden;
+}
+
 .dnssec-info-text {
 	margin-bottom: 12px;
 	font-size: medium;
@@ -141,3 +145,22 @@ dl dd {
 	margin-left: 50px;
 }
 
+/********** styling for showing diffs on a delivery service request **********/
+
+aside.current-value {
+	border: 1px solid #ddd;
+	margin: 10px;
+	padding: 10px;
+	position: relative;
+	border-radius: 4px;
+	background-color: #f5f5f5;
+	padding-left: 10px;
+	h3 {
+		width: 100%;
+		background-color: #3F5468;
+		color: white;
+		padding: 5px;
+		font-size: 13px;
+		margin-top: 10px;
+	}
+}