Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fixed cachegroup deliveryservice ISE#3566

Merged
mitchell852 merged 1 commit intoapache:masterfrom
moltzaum:cachegroups-ds-ise
May 16, 2019
Merged

Fixed cachegroup deliveryservice ISE#3566
mitchell852 merged 1 commit intoapache:masterfrom
moltzaum:cachegroups-ds-ise

Conversation

@moltzaum
Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Create a cachegroup with no severs.

Perform the following command:
curl -XPOST --cookie $mc -Lvsk https://localhost:6443/api/1.4/cachegroups/473/deliveryservices -d @cachegroup_deliveryservice.json | jq .

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
    • I don't think I could test anything useful.
  • This PR includes documentation OR I have explained why documentation is unnecessary
    • No new significant updates.
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
    • No new significant updates.
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented May 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3658/
Test FAILed.

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops bug something isn't working as intended labels May 13, 2019
@mitchell852
Copy link
Copy Markdown
Member

you could write a test that tries to

POST api/1.4/cachegroups/473/deliveryservices where 473 has zero caches and ensure that a 400 comes back...

@mitchell852 mitchell852 self-assigned this May 14, 2019
@mitchell852
Copy link
Copy Markdown
Member

retest this please

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented May 15, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3668/
Test PASSed.

@mitchell852 mitchell852 merged commit 92bd0ad into apache:master May 16, 2019
@moltzaum moltzaum deleted the cachegroups-ds-ise branch May 17, 2019 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/api/1.x/cachegroups/{{ID}}/deliveryservices endpoint should have a more informative error message

3 participants