Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Removed an unused/broken module from Traffic Portal#3636

Merged
mitchell852 merged 2 commits intoapache:masterfrom
ocket8888:removing-parameter-cache-groups
Oct 9, 2019
Merged

Removed an unused/broken module from Traffic Portal#3636
mitchell852 merged 2 commits intoapache:masterfrom
ocket8888:removing-parameter-cache-groups

Conversation

@ocket8888
Copy link
Contributor

What does this PR (Pull Request) do?

Removes a module from Traffic Portal that relies on an endpoint that doesn't exist

  • This PR is unrelated to any issue

Which Traffic Control components are affected by this PR?

  • Traffic Portal

Traffic Portal dependencies are not individually documented, and so no documentation changes are necessary.

What is the best way to verify this PR?

No functionality should have changed (except that errors will now be logged instead of ignored in many cases), so the existing tests should all pass.

Jeremy: actually, the only way to truly verify that the functionality did not change is to:

  1. run the UI tests (which is a very small subset of all TP functionality)
  2. manually verify the functionality associated with ALL the services functions that changed just to be sure all is well.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@mitchell852 mitchell852 added tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1 labels May 29, 2019
@ocket8888 ocket8888 force-pushed the removing-parameter-cache-groups branch from 8839ba8 to 4705a9d Compare July 23, 2019 15:46
@asfgit
Copy link
Contributor

asfgit commented Jul 23, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4001/
Test PASSed.

@rawlinp
Copy link
Contributor

rawlinp commented Jul 23, 2019

So today we can go to a cachegroup and view the parameters associated to that cachegroup. Was this stuff just meant to be the reverse of that -- going to a parameter and viewing the cachegroups associated to it?

I just want to make sure this doesn't remove the ability to go to a cachegroup and view the parameters associated to it, because that functionality is definitely in use.

@ocket8888
Copy link
Contributor Author

Yeah, the controller responsible for that would be the cacheGroupParameterService, I believe. So this is the inverse (reverse? converse?) of that, parameterCacheGroupService which would let you see the cache groups that use a parameter.

Of course, that assertion should be tested by both me and the reviewer. I'm pretty sure I did.

@asf-ci
Copy link
Contributor

asf-ci commented Oct 8, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4423/

@mitchell852
Copy link
Member

mitchell852 commented Oct 9, 2019

yes, i guess i never got around to allowing the user to view cachegroups assigned to a parameter but you can view parameters assigned to a cache group.

@mitchell852 mitchell852 merged commit 8c9d7bb into apache:master Oct 9, 2019
@ocket8888 ocket8888 deleted the removing-parameter-cache-groups branch October 9, 2019 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants