Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TP removes unused configurable ds field descriptions#3652

Merged
dangogh merged 1 commit intoapache:masterfrom
mitchell852:removes-unused-TP-properties
Jun 5, 2019
Merged

TP removes unused configurable ds field descriptions#3652
dangogh merged 1 commit intoapache:masterfrom
mitchell852:removes-unused-TP-properties

Conversation

@mitchell852
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 commented May 31, 2019

What does this PR (Pull Request) do?

When the delivery service (HTTP*, DNS*, Steering* and any_map) forms were enhanced to have better field tooltips, these configurable field descriptions were abandoned but never removed. This PR removes them.

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Start up TP and run the UI tests.

  • new UI tests would not be necessary for this. the existing tests will verify that functionality has not changed in the UI as a result of this change.
  • the configurability of ds field names/descriptions in TP was never documented so no need to remove any documentation.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 tech debt rework due to choosing easy/limited solution labels May 31, 2019
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented May 31, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3773/
Test PASSed.

Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI tests pass, help text popups still work.

@dangogh dangogh self-assigned this Jun 5, 2019
@dangogh dangogh merged commit e5d6040 into apache:master Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants