This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Improved TP UI tests performance and fixed up the README#3657
Merged
mitchell852 merged 1 commit intoapache:masterfrom Jun 5, 2019
Merged
Improved TP UI tests performance and fixed up the README#3657mitchell852 merged 1 commit intoapache:masterfrom
mitchell852 merged 1 commit intoapache:masterfrom
Conversation
Previously, each view change was accompanied by issuing a fresh request to the running TP instance. This means that every time a view was loaded, both Angular and Protractor need to run through their bootstrap and setup processes. This behavior has been replaced by the more proper navigation using AngularJS's router for 'in-page navigation'
mitchell852
added
Traffic Portal v1
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
mitchell852
added
the
improvement
mitchell852
approved these changes
Jun 5, 2019
Member
mitchell852
left a comment
mitchell852
left a comment
There was a problem hiding this comment.
UI tests pass but much quicker. nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Previously, each view change was accompanied by issuing a fresh request to the running TP instance. This means that every time a view was loaded, both Angular and Protractor need to run through their
bootstrap and setup processes. This behavior has been replaced by the more proper navigation using AngularJS's router for 'in-page navigation'
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the TP UI tests. If you don't know how to do that, that's perfect, because I also changed the README that describes how to run them. So also make sure they aren't too vague for you to run the tests.
The following criteria are ALL met by this PR