Add TO Go remap.config by rob05c · Pull Request #3688 · apache/trafficcontrol

rob05c · 2019-06-19T20:20:08Z

What does this PR (Pull Request) do?

Based on #3762 - highly recommend merging that first.

Converts remap.config to Traffic Ops Golang.

As with the other ATS configs, the code isn't ideal in some places, because it transliterates the Perl as closely as possible, for safety. I'm hoping we can convert these endpoints in two phases, transliterating, then refactoring, to be as safe as possible.

I've parity tested, against the old Perl for every production edge and mid we have, and they all diff identical (after sorting).

No documentation change, doesn't change the interface.

This PR is not related to any other issue

Which Traffic Control components are affected by this PR?

Traffic Ops

What is the best way to verify this PR?

Request the remap.config endpoint for a server, request it from an older TO, make sure they're identical after sorting (for ATS, map lines can be in any order, and on each line, plugin directives can be in any order as long as the associated pparam directives following them are the same).

If this is a bug fix, what versions of Traffic Ops are affected?

Not a bug fix.

The following criteria are ALL met by this PR

This PR includes tests OR I have explained why tests are unnecessary
This PR includes documentation OR I have explained why documentation is unnecessary
This PR includes an update to CHANGELOG.md OR such an update is not necessary
This PR includes any and all required license headers
This PR ensures that database migration sequence is correct OR this PR does not include a database migration
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

asfgit · 2019-06-19T20:25:44Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3877/
Test PASSed.

asfgit · 2019-07-01T21:52:41Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3924/
Test PASSed.

asfgit · 2019-07-02T00:21:59Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3925/
Test FAILed.

asfgit · 2019-07-03T00:59:35Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3935/
Test PASSed.

asfgit · 2019-07-03T15:55:20Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3936/
Test FAILed.

asfgit · 2019-07-03T16:19:03Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3937/
Test FAILed.

asfgit · 2019-07-03T16:31:39Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3938/
Test PASSed.

asfgit · 2019-07-18T16:25:13Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3986/
Test PASSed.

asfgit · 2019-08-06T16:27:48Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4105/
Test PASSed.

asf-ci · 2019-08-27T16:02:10Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4180/
Test FAILed.

asf-ci · 2019-08-27T16:02:59Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4181/
Test FAILed.

asf-ci · 2019-09-18T22:50:23Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4279/
Test PASSed.

Adds error logging whenever the config gen inserts multiple cacheurl or cachekey plugins on the same line. This isn't supported in ATS, and will usually do the wrong thing. But, we've always generated config like this, so for now, this doesn't change the config gen, but it logs the error

asf-ci · 2019-09-26T21:39:45Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4320/
Test PASSed.

asf-ci · 2019-09-26T21:40:33Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4321/
Test FAILed.

asf-ci · 2019-09-26T21:45:14Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4323/
Test FAILed.

asf-ci · 2019-09-26T21:48:42Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4324/
Test FAILed.

asf-ci · 2019-09-26T21:55:29Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4325/
Test PASSed.

lib/go-atscfg/remapdotconfig.go

traffic_ops/traffic_ops_golang/ats/db.go

asf-ci · 2019-09-27T22:10:27Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4344/
Test PASSed.

asf-ci · 2019-09-27T22:15:14Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4345/
Test PASSed.

asf-ci · 2019-09-27T22:50:22Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4346/
Test PASSed.

ocket8888

I feel like there could be a lot more GoDoc comments in here, but then we don't have a style guide that enforces it (yet).

traffic_ops/traffic_ops_golang/ats/server.go

lib/go-atscfg/remapdotconfig.go

lib/go-util/num.go

traffic_ops/ort/atstccfg/remapdotconfig.go

lib/go-atscfg/remapdotconfig.go

traffic_ops/ort/atstccfg/remapdotconfig.go

traffic_ops/traffic_ops_golang/ats/atsserver/parentdotconfig.go

lib/go-atscfg/remapdotconfig.go

asf-ci · 2019-10-01T23:20:09Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4375/

asf-ci · 2019-10-02T00:30:16Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4376/

asf-ci · 2019-10-02T01:22:51Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4377/

rob05c added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) cache-config Cache config generation labels Jun 19, 2019

rob05c mentioned this pull request Jun 19, 2019

WIP Traffic Ops Go ATS Configs - meta, profiles, remap.config #2991

Closed

17 tasks

rob05c force-pushed the to-go-atsconfig-remap branch from 432a02c to 8c609e6 Compare July 1, 2019 21:27

rob05c force-pushed the to-go-atsconfig-remap branch from 8c609e6 to 4feaeaf Compare July 1, 2019 23:07

rob05c force-pushed the to-go-atsconfig-remap branch from 4feaeaf to a9060f1 Compare July 3, 2019 00:40

rob05c force-pushed the to-go-atsconfig-remap branch from a9060f1 to 2ead12a Compare July 3, 2019 14:57

rob05c removed the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Jul 3, 2019

rob05c marked this pull request as ready for review July 3, 2019 15:41

rob05c force-pushed the to-go-atsconfig-remap branch 2 times, most recently from 366cb53 to 516293c Compare July 3, 2019 15:50

rob05c force-pushed the to-go-atsconfig-remap branch from 516293c to cf35a4c Compare July 18, 2019 16:06

rob05c force-pushed the to-go-atsconfig-remap branch from cf35a4c to cc778a2 Compare August 6, 2019 15:45

rob05c force-pushed the to-go-atsconfig-remap branch 4 times, most recently from 2aa3fe0 to 0b72e5f Compare August 27, 2019 15:46

rob05c force-pushed the to-go-atsconfig-remap branch 2 times, most recently from c007818 to 21fd6a9 Compare September 26, 2019 21:02

rob05c added 2 commits September 26, 2019 15:34

Add TO Go remap.config

3f1e3eb

rob05c force-pushed the to-go-atsconfig-remap branch from 19b8d39 to 406f040 Compare September 26, 2019 21:35

Add atstccfg (TO ATS config gen) remap.config

d099a22

rob05c force-pushed the to-go-atsconfig-remap branch from 406f040 to d099a22 Compare September 26, 2019 21:47

alficles suggested changes Sep 27, 2019

View reviewed changes

lib/go-atscfg/remapdotconfig.go Outdated Show resolved Hide resolved

lib/go-atscfg/remapdotconfig.go Show resolved Hide resolved

traffic_ops/traffic_ops_golang/ats/db.go Show resolved Hide resolved

traffic_ops/traffic_ops_golang/ats/db.go Outdated Show resolved Hide resolved

rob05c added 2 commits September 27, 2019 16:02

Fix godoc comments

69100bc

Change sort.Sort(sort.StringSlice to sort.Strings

f7ee9a0

Fix atscfg ATS major version for >9.

120c64c

alficles approved these changes Sep 27, 2019

View reviewed changes

ocket8888 suggested changes Oct 1, 2019

View reviewed changes

rob05c added 2 commits October 1, 2019 15:16

Add GoDoc for util.HashInts

ae67304

Change for loop to strings.Join

e71ec72

rob05c force-pushed the to-go-atsconfig-remap branch from 171aeee to e71ec72 Compare October 1, 2019 21:26

ocket8888 approved these changes Oct 1, 2019

View reviewed changes

ocket8888 merged commit efef336 into apache:master Oct 2, 2019

Conversation

rob05c commented Jun 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Ops are affected?

The following criteria are ALL met by this PR

Uh oh!

asfgit commented Jun 19, 2019

Uh oh!

asfgit commented Jul 1, 2019

Uh oh!

asfgit commented Jul 2, 2019

Uh oh!

asfgit commented Jul 3, 2019

Uh oh!

asfgit commented Jul 3, 2019

Uh oh!

asfgit commented Jul 3, 2019

Uh oh!

asfgit commented Jul 3, 2019

Uh oh!

asfgit commented Jul 18, 2019

Uh oh!

asfgit commented Aug 6, 2019

Uh oh!

asf-ci commented Aug 27, 2019

Uh oh!

asf-ci commented Aug 27, 2019

Uh oh!

asf-ci commented Sep 18, 2019

Uh oh!

asf-ci commented Sep 26, 2019

Uh oh!

asf-ci commented Sep 26, 2019

Uh oh!

asf-ci commented Sep 26, 2019

Uh oh!

asf-ci commented Sep 26, 2019

Uh oh!

asf-ci commented Sep 26, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asf-ci commented Sep 27, 2019

Uh oh!

asf-ci commented Sep 27, 2019

Uh oh!

asf-ci commented Sep 27, 2019

Uh oh!

ocket8888 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asf-ci commented Oct 1, 2019

Uh oh!

asf-ci commented Oct 2, 2019

Uh oh!

asf-ci commented Oct 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rob05c commented Jun 19, 2019 •

edited

Loading