This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Some best-practices updates to the kickstart script#3691
Merged
Conversation
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
mitchell852
added
improvement
ocket8888
force-pushed
the
kickstart-best-practices
branch
from
d33aa91 to
369897c
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
rawlinp
suggested changes
Sep 4, 2019
ocket8888
force-pushed
the
kickstart-best-practices
branch
from
369897c to
f12ce64
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
rawlinp
reviewed
Sep 13, 2019
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
This one's getting there, but the spaces between between print and (...) like print (...) are weirding me out.
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
rawlinp
approved these changes
Sep 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR makes some best-practices updates to the script responsible for generating the "network line" for kickstart ISO creation. Puts parenthesis around
printstatement args, better implementation ofstr.formatandstr.join, replaces a check for identity equality with the proper check for value equality, removed an unused variable, checking for presence of a member of aset/dictwithin/not ininstead of deprecated methods and/or weird argument nesting, etc.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Generate an ISO through a Traffic Ops instance that has the new version of the script, verify that it comes out correctly. The script has no tests, but you could also just check the output using Docker or a VM.
The following criteria are ALL met by this PR