Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

CLOSED - TP: adds the ability to rearrange delivery service table columns as well as toggle column visibility/searchability#3722

Closed
mitchell852 wants to merge 20 commits intoapache:masterfrom
mitchell852:column-config-ds
Closed

CLOSED - TP: adds the ability to rearrange delivery service table columns as well as toggle column visibility/searchability#3722
mitchell852 wants to merge 20 commits intoapache:masterfrom
mitchell852:column-config-ds

Conversation

@mitchell852
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 commented Jul 15, 2019 •
edited
Loading

NOTE: #3680 needs to be merged before this one.

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

This PR adds checkboxes to toggle the visiblity/searchability of ds table columns as well as adds the ability to reorder the columns.

image

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Navigate to https://tp.doman.com/#!/delivery-services and

  1. reorder the columns; refresh the screen to ensure that the new order persists itself across browser sessions.
  2. click on the drop down to toggle the visiblity/searchability of columns; refresh the screen to ensure that the selected columns are visible/hidden across browser sessions. also, ensure that values in hidden columns are not considered in the table search.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

mitchell852 added 19 commits July 2, 2019 08:05
@mitchell852
adds the ability to rearrange table columns as well as toggle column …
4d31f45 
…visiblity/searchability - started with types table
@mitchell852
updates jquery datatables to version 1.10.19
8de8ad5
@mitchell852
adds column name to saved state
7fb2969
@mitchell852
removed jquery click event handler in favor of angular approach
2b15729 
leveraged new col.name property to enable ng-repeat on column checkboxes
@mitchell852
reordered default columns
30bfb1b
@mitchell852
added logic to the jquery datatables to handle the searchable propert…
537ba00 
…y when visible is changed.
@mitchell852
renamed the jquery.datatables library and added proper licenses
870315c
@mitchell852
uses localstorage api
3d8e926
@mitchell852
checks for local storage and removes an unused startup method
125af47
@mitchell852
using menu tag instead of ul/li
b81f4c0
@mitchell852
fixes license for colReorder.datatables
0e8a7be
@mitchell852
provides an informative console message if localstorage parse fails
36e87c2
@mitchell852
reverts to the the unpatched version of jquery datatables so any chan…
c31c441 
…ges can be captured in history via a seperate PR
@mitchell852
reminified jquery datatables js file and added comments about the mod…
e85981f 
…ifications that were made
@mitchell852
menuitem tag was deprecated
16a975d
@mitchell852
ensures that showing/hiding table columns always keeps the table at 1…
91ce4a0 
…00% width
@mitchell852
updated the default column order and used an orderby to order the col…
de58a92 
…umn checkboxes
@mitchell852
removes name attribute from tds
62174d9
@mitchell852
removes the actions column from the ds tables to prep for configurabl…
f61cf11 
…e ds columns (order, search, visiblity)
@mitchell852 mitchell852 added new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1 labels Jul 15, 2019
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jul 15, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3970/
Test PASSed.

@mitchell852 mitchell852 force-pushed the column-config-ds branch 2 times, most recently from e5a83be to 4fd8269 Compare July 17, 2019 16:02
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jul 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3979/
Test FAILed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jul 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3980/
Test FAILed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jul 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3981/
Test FAILed.

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jul 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3983/
Test PASSed.

@mitchell852
Copy link
Copy Markdown
Member Author

mitchell852 commented Jul 18, 2019

closing this in favor of #3739 as i was having difficulties with git conflicts.

@mitchell852 mitchell852 changed the title TP: adds the ability to rearrange delivery service table columns as well as toggle column visibility/searchability CLOSED - TP: adds the ability to rearrange delivery service table columns as well as toggle column visibility/searchability Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

abandoned new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mitchell852 @asfgit