This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Rewrote /user/logout to Go#3903
Merged
Merged
Conversation
ocket8888
added
Traffic Ops
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
ocket8888
force-pushed
the
user-logout-go
branch
from
e67f4e7 to
0a39f7f
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
mhoppa
approved these changes
Sep 26, 2019
Contributor
mhoppa
left a comment
mhoppa
left a comment
There was a problem hiding this comment.
one very minor nit comment - feel free to ignore.
Pulled locally and tested great.
Only other consideration would be if this warrants an API test or not
ocket8888
force-pushed
the
user-logout-go
branch
from
0a39f7f to
ff82903
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
ocket8888
force-pushed
the
user-logout-go
branch
from
ff82903 to
0e9d99a
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Rewrote /user/logout to Go
Which Traffic Control components are affected by this PR?
functionality is not changing, so no docs
What is the best way to verify this PR?
Authenticate as normal, then just logout. Normally, this would be done in Traffic Portal through the button on the sidebar. Then just observe that you're not authenticated - no endpoints (except
/ping) should respond with anything other than an "Unauthenticated" errorThe following criteria are ALL met by this PR