Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix typo in GetProfileDS query used to generate cache.config#3940

Merged
mitchell852 merged 1 commit into
apache:masterfrom
rob05c:to-fix-typo
Sep 30, 2019
Merged

Fix typo in GetProfileDS query used to generate cache.config#3940
mitchell852 merged 1 commit into
apache:masterfrom
rob05c:to-fix-typo

Conversation

@rob05c
Copy link
Copy Markdown
Member

@rob05c rob05c commented Sep 30, 2019

Fix typo from merge conflict

What does this PR (Pull Request) do?

Fix typo from merge conflict

No documentation, no interface change.
Endpoint already has tests, they caught this.

  • This PR fixes #REPLACE_ME OR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

curl ats config endpoints.

If this is a bug fix, what versions of Traffic Control are affected?

no versions

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@rob05c rob05c added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Sep 30, 2019
@mitchell852 mitchell852 added the cache-config Cache config generation label Sep 30, 2019
@mitchell852 mitchell852 changed the title Fix typo Fix typo in GetProfileDS query used to generate cache.config Sep 30, 2019
@mitchell852 mitchell852 merged commit ecefac1 into apache:master Sep 30, 2019
@mhoppa
Copy link
Copy Markdown
Contributor

mhoppa commented Sep 30, 2019

Great find!! Are there API tests in place that would have caught this issue?

@rob05c
Copy link
Copy Markdown
Member Author

rob05c commented Sep 30, 2019

@mhoppa I thought it did cause the API tests to fail, but I was mistaken. I added tests: #3941

They only test the 200, which catches this issue. They don't extensively test that the config is correct; but, we're moving to cache-side generation and these endpoints won't be used anymore, so it isn't worth adding lots of logic tests. The right place for more of those is the lib/go-atscfg unit tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended cache-config Cache config generation Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants