This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix typo in GetProfileDS query used to generate cache.config#3940
Merged
Conversation
mhoppa
approved these changes
Sep 30, 2019
Contributor
|
Great find!! Are there API tests in place that would have caught this issue? |
Member
Author
|
@mhoppa I thought it did cause the API tests to fail, but I was mistaken. I added tests: #3941 They only test the 200, which catches this issue. They don't extensively test that the config is correct; but, we're moving to cache-side generation and these endpoints won't be used anymore, so it isn't worth adding lots of logic tests. The right place for more of those is the lib/go-atscfg unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo from merge conflict
What does this PR (Pull Request) do?
Fix typo from merge conflict
No documentation, no interface change.
Endpoint already has tests, they caught this.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
curl ats config endpoints.
If this is a bug fix, what versions of Traffic Control are affected?
no versions
The following criteria are ALL met by this PR