TP: by default only show parameter diff when comparing 2 profiles by mitchell852 · Pull Request #3963 · apache/trafficcontrol

mitchell852 · 2019-10-07T21:32:04Z

What does this PR (Pull Request) do?

This PR changes the default behavior when comparing the parameters of 2 profiles:

current behavior (#3919 ): ALL parameters (shared and not shared) are displayed.

new behavior: As requested by users, ONLY the parameters that belong to one profile and NOT the other (the diff) are displayed by DEFAULT and the user is given the option to "Show Shared Params" if so desired.

This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?

Launch TP

Navigate to https://tp.domain.com/#!/profiles
Select "Compare Profiles" under the More button
Select 2 profiles to compare
Ensure none of the "shared" parameters are displayed
add or remove parameters from each profile; click "Update"
ensure the comparison is updated correctly after confirmation.

Navigate to https://tp.domain.com/#!/profiles
Select "Compare Profiles" under the More button
Select 2 profiles to compare
Select 'Show Shared Params'
Ensure each profile has the proper parameters "checked". (you can double check by checking the parameters for the profile at https://tp.domain.com/#!/profiles/{profile_id}/parameters)
add or remove parameters from each profile; click "Update"
ensure the proper parameters are assigned to each profile after confirmation.

The following criteria are ALL met by this PR

The tests associated with TP: adds a better view for comparing/managing params of 2 profiles #3919 cover this new feature however a minor change was required
This PR includes documentation
The CHANGELOG.md entry for TP: adds a better view for comparing/managing params of 2 profiles #3919 is still applicable
This PR includes any and all required license headers
This PR ensures that database migration sequence is correct OR this PR does not include a database migration
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

…ge with unsaved changes

…vide the option to see all params as well

asf-ci · 2019-10-08T01:12:17Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4413/

…ameter diff as the default view when comparing profile params

asf-ci · 2019-10-08T15:40:40Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4417/

asf-ci · 2019-10-15T14:54:25Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4512/

asf-ci · 2019-10-15T14:55:46Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4513/

ocket8888 · 2019-10-15T16:06:06Z

retest this please

asf-ci · 2019-10-15T16:17:22Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4517/

ocket8888 · 2019-10-15T16:29:24Z

retest this please

asf-ci · 2019-10-15T16:31:58Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4520/

ocket8888 · 2019-10-15T16:43:54Z

retest this please

asf-ci · 2019-10-15T17:06:44Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4523/

ocket8888 · 2019-10-15T17:37:54Z

retest this please

asf-ci · 2019-10-15T17:42:21Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4524/

…pend on underscore

asf-ci · 2019-10-15T19:20:13Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4529/

asf-ci · 2019-10-15T21:20:20Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4531/

ocket8888

Works, tests pass, looks good visually, doesn't use _.js, docs compile and read fine

mitchell852 added 2 commits October 7, 2019 14:08

adds support for a confirmation dialog when navigating away from a pa…

d8132a6

…ge with unsaved changes

when comparing profiles, only show parameter diffs by default but pro…

b766e0e

…vide the option to see all params as well

mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 improvement The functionality exists but it could be improved in some way. labels Oct 8, 2019

updates docs to reflect changes added to support having a profile par…

269022d

…ameter diff as the default view when comparing profile params

mitchell852 marked this pull request as ready for review October 8, 2019 15:45

mitchell852 requested a review from ocket8888 October 15, 2019 14:40

changes the verbiage from diff to compare

56fde99

mitchell852 force-pushed the profile-diff-2 branch from dd18a45 to 56fde99 Compare October 15, 2019 14:48

ocket8888 suggested changes Oct 15, 2019

View reviewed changes

Comment thread traffic_portal/app/src/modules/private/profiles/compare/diff/index.js Outdated

Comment thread traffic_portal/app/src/common/service/utils/LocationUtils.js Outdated

mitchell852 added 2 commits October 15, 2019 13:12

creates a unique array of object based on a key value and does not de…

d0f1408

…pend on underscore

removes dialog cancel handler that does nothing

53fbc4d

ocket8888 approved these changes Oct 15, 2019

View reviewed changes

ocket8888 merged commit 876784e into apache:master Oct 15, 2019

Conversation

mitchell852 commented Oct 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

The following criteria are ALL met by this PR

Uh oh!

asf-ci commented Oct 8, 2019

Uh oh!

asf-ci commented Oct 8, 2019

Uh oh!

asf-ci commented Oct 15, 2019

Uh oh!

asf-ci commented Oct 15, 2019

Uh oh!

ocket8888 commented Oct 15, 2019

Uh oh!

asf-ci commented Oct 15, 2019

Uh oh!

ocket8888 commented Oct 15, 2019

Uh oh!

asf-ci commented Oct 15, 2019

Uh oh!

ocket8888 commented Oct 15, 2019

Uh oh!

asf-ci commented Oct 15, 2019

Uh oh!

ocket8888 commented Oct 15, 2019

Uh oh!

asf-ci commented Oct 15, 2019

Uh oh!

Uh oh!

Uh oh!

asf-ci commented Oct 15, 2019

Uh oh!

asf-ci commented Oct 15, 2019

Uh oh!

ocket8888 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mitchell852 commented Oct 7, 2019 •

edited

Loading