This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Remove Traffic Ops Golang legacy tc.ApiErrorType#3988
Merged
ocket8888 merged 4 commits intoapache:masterfrom Oct 16, 2019
Merged
Remove Traffic Ops Golang legacy tc.ApiErrorType#3988ocket8888 merged 4 commits intoapache:masterfrom
ocket8888 merged 4 commits intoapache:masterfrom
Conversation
Contributor
|
Can one of the admins verify this patch? |
mitchell852
added
Traffic Ops
zrhoffman
changed the title
mhoppa
reviewed
Oct 15, 2019
Contributor
mhoppa
left a comment
mhoppa
left a comment
There was a problem hiding this comment.
Looks good, I do have one question I left as a comment.
The unit tests, go fmt and api tests pass though so good work.
mhoppa
approved these changes
Oct 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
ApiErrorType is not mentioned in the documentation, so its removal does not need to affect documentation.
What is the best way to verify this PR?
If this is a bug fix, what versions of Traffic Control are affected?
Not a bug fix.
The following criteria are ALL met by this PR