Rewrote /deliveryservices/request to Go by ocket8888 · Pull Request #3989 · apache/trafficcontrol

ocket8888 · 2019-10-14T15:16:03Z

What does this PR (Pull Request) do?

This PR fixes Rewrite /deliveryservices/request to Go #3855

Rewrites deliveryservices/request to Go.

Which Traffic Control components are affected by this PR?

Documentation
Traffic Ops

What is the best way to verify this PR?

Build the Traffic Ops RPM, install it somewhere with access to an SMTP server, configure it to use that server for sending mail, then request a Delivery Service via the deliveryservices/request endpoint.

This PR does not include tests, because there is currently no way to test functionality that depends on an external SMTP server.

The following criteria are ALL met by this PR

This PR includes tests OR I have explained why tests are unnecessary
This PR includes documentation OR I have explained why documentation is unnecessary
This PR includes an update to CHANGELOG.md OR such an update is not necessary
This PR includes any and all required license headers
This PR ensures that database migration sequence is correct OR this PR does not include a database migration
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

asf-ci · 2019-10-14T15:17:05Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4490/

asf-ci · 2019-10-14T16:07:00Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4494/

asf-ci · 2019-10-14T17:00:33Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4495/

mhoppa

this PR looks good. I left a couple of comments but all minor/nit. Going to pull down to test prior to approval

lib/go-tc/enum.go

lib/go-tc/deliveryservice_requests.go

mhoppa

some fields have the wrong type

lib/go-tc/deliveryservice_requests.go

asf-ci · 2019-10-17T23:32:12Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4572/

asf-ci · 2019-10-18T18:12:02Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4577/

ocket8888 · 2019-10-18T21:22:01Z

retest this please

asf-ci · 2019-10-18T21:27:04Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4580/

ocket8888 · 2019-10-18T21:34:04Z

retest this please

asf-ci · 2019-10-18T21:37:10Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4581/

mhoppa

The example post in the docs shouldnt be an invalid request as I am getting. FWIW all the bools are causing hasNegativeCachingCustomization: cannot be blank

Might be good to add some validation unit tests

asf-ci · 2019-10-21T18:21:49Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4590/

asf-ci · 2019-10-21T18:26:58Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4591/

ocket8888 · 2019-10-21T18:28:24Z

The request example in the docs isn't invalid - I accidentally changed some fields to strings that shouldn't have been when I was making changes you requested above.

asf-ci · 2019-10-21T18:41:18Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4593/

asf-ci · 2019-10-21T18:51:48Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4594/

mhoppa

Tested locally and works as expected.

ocket8888 · 2019-10-21T19:22:08Z

retest this please

asf-ci · 2019-10-21T19:27:25Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4597/

lib/go-tc/deliveryservice_requests.go

asf-ci · 2019-10-21T19:47:53Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4598/

ocket8888 force-pushed the dsrequests-go branch from 838a8b0 to 8963843 Compare October 14, 2019 16:04

ocket8888 force-pushed the dsrequests-go branch from 8963843 to ead578f Compare October 14, 2019 16:54

ocket8888 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution labels Oct 14, 2019

ocket8888 added this to the Go Rewrite milestone Oct 14, 2019

ocket8888 marked this pull request as ready for review October 14, 2019 17:26

ocket8888 changed the title ~~Dsrequests go~~ Rewrote /deliveryservices/request to Go Oct 14, 2019

mhoppa reviewed Oct 15, 2019

View reviewed changes

lib/go-tc/enum.go Outdated Show resolved Hide resolved

lib/go-tc/deliveryservice_requests.go Outdated Show resolved Hide resolved

lib/go-tc/deliveryservice_requests.go Outdated Show resolved Hide resolved

mhoppa suggested changes Oct 16, 2019

View reviewed changes

lib/go-tc/deliveryservice_requests.go Outdated Show resolved Hide resolved

lib/go-tc/deliveryservice_requests.go Outdated Show resolved Hide resolved

mhoppa reviewed Oct 16, 2019

View reviewed changes

lib/go-tc/deliveryservice_requests.go Outdated Show resolved Hide resolved

ocket8888 force-pushed the dsrequests-go branch from f711eed to f0ec968 Compare October 18, 2019 18:07

mhoppa suggested changes Oct 21, 2019

View reviewed changes

ocket8888 added 7 commits October 21, 2019 12:23

Rewrote deliveryservice/request to Go

45f29cc

updated CHANGELOG

37ab33a

Use api library to write alert response

9ad35d8

Fixed erroneous docs

9c6dce2

Using ozzo-validations to validate DSR fields

e6d6ad9

Fix docs with incorrect field types in request example

414c16d

Fix empty originHeaders arrays allowed

6b06e30

ocket8888 force-pushed the dsrequests-go branch from 319bd50 to 6fc08b2 Compare October 21, 2019 18:23

ocket8888 force-pushed the dsrequests-go branch from 6fc08b2 to 7762fde Compare October 21, 2019 18:36

Fix incorrect checks for nil boolean fields

b241dd3

ocket8888 force-pushed the dsrequests-go branch from 7762fde to b241dd3 Compare October 21, 2019 18:47

mhoppa approved these changes Oct 21, 2019

View reviewed changes

rawlinp suggested changes Oct 21, 2019

View reviewed changes

lib/go-tc/deliveryservice_requests.go Outdated Show resolved Hide resolved

rawlinp self-assigned this Oct 21, 2019

remove unnecessary switch checking for valid DSTypes

04662eb

ocket8888 force-pushed the dsrequests-go branch from e792844 to 04662eb Compare October 21, 2019 19:45

rawlinp approved these changes Oct 21, 2019

View reviewed changes

rawlinp merged commit 0974c74 into apache:master Oct 21, 2019

ocket8888 deleted the dsrequests-go branch October 21, 2019 20:31

Conversation

ocket8888 commented Oct 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

The following criteria are ALL met by this PR

Uh oh!

asf-ci commented Oct 14, 2019

Uh oh!

asf-ci commented Oct 14, 2019

Uh oh!

asf-ci commented Oct 14, 2019

Uh oh!

mhoppa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhoppa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asf-ci commented Oct 17, 2019

Uh oh!

asf-ci commented Oct 18, 2019

Uh oh!

ocket8888 commented Oct 18, 2019

Uh oh!

asf-ci commented Oct 18, 2019

Uh oh!

ocket8888 commented Oct 18, 2019

Uh oh!

asf-ci commented Oct 18, 2019

Uh oh!

mhoppa left a comment

Choose a reason for hiding this comment

Uh oh!

asf-ci commented Oct 21, 2019

Uh oh!

asf-ci commented Oct 21, 2019

Uh oh!

ocket8888 commented Oct 21, 2019

Uh oh!

asf-ci commented Oct 21, 2019

Uh oh!

asf-ci commented Oct 21, 2019

Uh oh!

mhoppa left a comment

Choose a reason for hiding this comment

Uh oh!

ocket8888 commented Oct 21, 2019

Uh oh!

asf-ci commented Oct 21, 2019

Uh oh!

Uh oh!

asf-ci commented Oct 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ocket8888 commented Oct 14, 2019 •

edited

Loading