This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Adding ability to use zone root records#4107
Open
smalenfant wants to merge 13 commits into
Open
Conversation
Contributor
|
Can one of the admins verify this patch? |
ocket8888
reviewed
Nov 15, 2019
Requires a non-empty string. @, * and hostnames
85ddc4f to
ef81d1e
Compare
rawlinp
suggested changes
May 28, 2020
Contributor
rawlinp
left a comment
There was a problem hiding this comment.
Do you mind adding an entry to CHANGELOG.md for this enhancement?
zrhoffman
reviewed
May 28, 2020
zrhoffman
approved these changes
Mar 17, 2022
Member
zrhoffman
left a comment
There was a problem hiding this comment.
staticDNSEntry.Host validation regex looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Allowing empty name zone name records.
For example, if your Delivery Service FQDN is test.cdn.isp.net, allow to set an A/AAAA/TXT/CNAME records for that hostname.
At the time of writing this PR, there is no change to the API or Traffic Portal which do not allow empty names. Changes need to be done directly in the database (which does allow empty name).
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
This requires to be able to add a static entry in the database using an empty name.
Result:
Dig verification :
If this is a bug fix, what versions of Traffic Control are affected?
This is an enhancement
The following criteria are ALL met by this PR
Additional Information
More changes required in Traffic Ops API and Traffic Portal.