This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TP - removes deep zone coverage file checkbox from cache group form#4172
Merged
rawlinp merged 1 commit intoDec 5, 2019
Merged
Conversation
mitchell852
force-pushed
the
issue-3607-remove-dczf-checkbox
branch
from
7a2c6cd to
f931af5
Compare
… dczf is enabled on a cachegroup. did some refactoring to clean up how the localization methods are added/removed from the cg object when the checkboxes are clicked.
mitchell852
force-pushed
the
issue-3607-remove-dczf-checkbox
branch
from
f931af5 to
afca24a
Compare
mitchell852
added
Traffic Portal v1
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
rawlinp
approved these changes
Dec 5, 2019
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
Looks good from a code perspective, and thanks for refactoring my bad js code :). I'll pull this down and test before merging.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
removes dzcf checkbox as it is not a real indicator of whether or not dczf is enabled on a cachegroup.
also, did some refactoring to clean up how the localization methods are added/removed from the cachegroup object when the checkboxes are clicked.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
The following criteria are ALL met by this PR