Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TP: bug fixes on the any map form#4199

Merged
ocket8888 merged 9 commits intoapache:masterfrom
mitchell852:fixes-any_map_form
Dec 17, 2019
Merged

TP: bug fixes on the any map form#4199
ocket8888 merged 9 commits intoapache:masterfrom
mitchell852:fixes-any_map_form

Conversation

@mitchell852
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 commented Dec 11, 2019

What does this PR (Pull Request) do?

This PR actually fixes 4 issues. I could have done 4 PR's but figured since each is so small and related to the any map delivery service form, I'd just submit one PR.

This PR also makes "Raw Remap Text" a required field on the ANY_MAP DS form otherwise the DS cannot serve content.

  • The Any Map ds form is not currently documented, therefore, making changes does not require a documentation change.
  • The existing UI tests server as an adequate regression test of the any map delivery service form.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Issue #1943:

  • ensure that the Routing Configuration Settings section has been removed from the ANY_MAP delivery service form.

Issue #2426:

  • ensure that the "Manage Invalidation Requests" menu item does not exist under More on the any map delivery service form.

Issue #4102

  • ensure that the delivery service URLs section has been removed from the ANY_MAP delivery service form.

Issue #4201 :

  • ensure that the "Manage Regexes" and "Manage Static DNS Entries" menu item does not exist under More on the any map delivery service form.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 labels Dec 11, 2019
@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4915/

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4916/

…the any map ds form as those items are utilized by TR and TR does not handle any map delivery services.
@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4918/

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4919/

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 12, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4925/

Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but as long as we're fixing things up, the "Raw Remap Text" part ought to be required for ANY_MAP since they cannot serve content without it.

@mitchell852
Copy link
Copy Markdown
Member Author

This looks fine, but as long as we're fixing things up, the "Raw Remap Text" part ought to be required for ANY_MAP since they cannot serve content without it.

done

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 16, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4939/

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 16, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4945/

Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI tests are broken. I don't know if this is the full scope of the problem, but the should populate and submit the delivery service form test expects the Create button to be enabled despite entering no raw remap text for an ANY_MAP Delivery Service.

@mitchell852
Copy link
Copy Markdown
Member Author

UI tests are broken. I don't know if this is the full scope of the problem, but the should populate and submit the delivery service form test expects the Create button to be enabled despite entering no raw remap text for an ANY_MAP Delivery Service.

oh man. my bad. forgot to run the UI tests after adding that required field.

@mitchell852
Copy link
Copy Markdown
Member Author

UI test fixed

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Dec 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4952/

@ocket8888 ocket8888 merged commit 6266cf1 into apache:master Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

3 participants