Prevents line breaks in delivery service remapText field (UI and API)

[mitchell852]

What does this PR (Pull Request) do?

Rejects delivery service remapText with line breaks as it will result in a malformed remap.config file.

• This PR fixes Line breaks in DS raw remap text will result in a malformed remap.config file  #4298

Which Traffic Control components are affected by this PR?

• Traffic Ops
• Traffic Portal

What is the best way to verify this PR?

1. Run the UI tests
2. Run the API tests
3. Manually verify in TP by trying to enter a line break in the Raw Remap Text delivery service form field for a DNS, HTTP or ANY_MAP delivery service.
4. Attempt to create or update a delivery service using the API where remapText contains \n or \r. It should fail.

If this is a bug fix, what versions of Traffic Control are affected?

• master (6b11bd9)
• 3.1.0
• 4.0.0 (RC1)

The following criteria are ALL met by this PR

• This PR includes tests OR I have explained why tests are unnecessary
• This PR includes documentation OR I have explained why documentation is unnecessary
• This PR includes an update to CHANGELOG.md OR such an update is not necessary
• This PR includes any and all required license headers
• This PR ensures that database migration sequence is correct OR this PR does not include a database migration
• This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

[ocket8888]

The regular expression you're using isn't multi-line; ^ and $ match the beginning and end of a line, respectively. So I can still do this:

>> temp0.name
<- "remapText"
>> temp0.tagName
<- "TEXTAREA"
>> temp0.attributes[4]
<- ng-pattern="/^[^\\n\\r]*$/"
>> temp0.value
<- "
this is a test
"
>> temp0.validity.patternMismatch
<- false
>> temp0.classList.contains("ng-invalid")
<- false
>> temp0.classList.contains("ng-valid")
<- true

[mitchell852]

The regular expression you're using isn't multi-line; ^ and $ match the beginning and end of a line, respectively. So I can still do this:

>> temp0.name
<- "remapText"
>> temp0.tagName
<- "TEXTAREA"
>> temp0.attributes[4]
<- ng-pattern="/^[^\\n\\r]*$/"
>> temp0.value
<- "
this is a test
"
>> temp0.validity.patternMismatch
<- false
>> temp0.classList.contains("ng-invalid")
<- false
>> temp0.classList.contains("ng-valid")
<- true

well in the UI i am unable to enter anything on 2+ lines so that's what i was going for. for example

^^ is fine as it appears to get trimmed

2 lines with content isn't allowed.

[ocket8888]

No, you still can.

That'll get rejected by the API but the form shows no problems. According to the issue, the content of this field is:

"appended to the one line [in remap.config for most Delivery Services]"

so this value would still exhibit the problem. So it ought to not be considered correct - especially since submission will result in an error.

[mitchell852]

so this value would still exhibit the problem. So it ought to not be considered correct - especially since submission will result in an error.

hmm. i can't replicate. this submits fine in both chrome and firefox as i would hope.

it makes it past the api so it appears to be getting trimmed. also, remap.config looks fine when i submit that value ^^

it's only when i added a value on a 2nd line that the field becomes invalid which is what i want.

[mitchell852]

retest this please

[ocket8888]

API/client integration tests pass (unrelated failure in TestStatsSummary notwithstanding), unit tests pass, you didn't add a TP UI test so I assume those all still pass (though honestly that'd be nice), manual requests show newlines rejected by API and for some reason I can't explain the ng-model bindings on textareas silently trim leading and trailing whitespace so that isn't really a problem either.

[ocket8888]

Actually, after running the tests again against this branch rebased on master and master itself, TestStatsSummary is failing only after this branch's changes. I have no idea how or why, but that seems to be the case.

[ocket8888]

Nevermind again, that was just a transient, inexplicable, temporary failure :))))))))))))))))))))