This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Backport 4.0.x: Fix ip_allow config generation for mids to include rascal servers #4308
Merged
rawlinp merged 1 commit intoapache:4.0.xfrom Jan 21, 2020
Merged
Backport 4.0.x: Fix ip_allow config generation for mids to include rascal servers #4308rawlinp merged 1 commit intoapache:4.0.xfrom
rawlinp merged 1 commit intoapache:4.0.xfrom
Conversation
rawlinp
added
Traffic Ops
…ache#4296) * Fix ip_allow config generation to include rascal servers * Fix ip_allow generation in atstccfg * Add API tests for ip_allow * Make tests more robust (cherry picked from commit 6b11bd9)
mhoppa
force-pushed
the
bug/fix_ip_config
branch
from
ce0b090 to
0c6d2b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from #4296)
What does this PR (Pull Request) do?
Currently in ip_allow.config generation for mids it does not include rascal server IPs causing them to be blocked on attempting to pull astats.
The behavior in the perl implementation is that it would include all servers of type Rascal as well as EDGEs that are in either parent/secondary cachegroup of the mid. https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L2210-L2228
TO GO API Bug
In the go TO implementation it checks the parent/secondary cachegroup on both Rascal AND Edge servers which is a mismatch of logic.
Going from
is rascal OR (is edge AND edge.cg in (mid parent cg, mid secondary cg)tois rascal OR edge AND s.cg in (mid parent cg, mid secondary cg)atstccfg Bug
In the atstccfg cfg it does not attempt to include rascal servers
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Generate the ip_allow.cfg for a mid and ensure the rascal servers are included via TO API and atstccfg
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information