This repository was archived by the owner on Nov 24, 2025. It is now read-only.
traffic_ops_ort: fix for syncds having too many header rewrite false …#4343
Merged
rob05c merged 2 commits intoapache:masterfrom Jan 30, 2020
Merged
traffic_ops_ort: fix for syncds having too many header rewrite false …#4343rob05c merged 2 commits intoapache:masterfrom
rob05c merged 2 commits intoapache:masterfrom
Conversation
rawlinp
added
bug
…iff_file_lines function
rob05c
reviewed
Jan 29, 2020
alficles
approved these changes
Jan 30, 2020
Contributor
alficles
left a comment
alficles
left a comment
There was a problem hiding this comment.
LGTM. Does what it says on the tin.
rob05c
approved these changes
Jan 30, 2020
Member
rob05c
left a comment
rob05c
left a comment
There was a problem hiding this comment.
Looks good, thanks!
I tested running ORT, this fixes the false positives on header rewrites problem, syncds didn't update files that hadn't changed. I also made changes to header rewrite and other configs, and verified real changes still get placed properly.
The code also looks good to me (though I'm not a Perl Wizard).
rawlinp
pushed a commit
to rawlinp/trafficcontrol
that referenced
this pull request
Jan 31, 2020
apache#4343) * traffic_ops_ort: fix for syncds having too many header rewrite false positives * traffic_ops_ort.pl: allow all files with changes to run through the diff_file_lines function (cherry picked from commit 7ee3ffa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…positives
What does this PR (Pull Request) do?
This PR fixes an issue when canned comments aren't consistently stripped for header_rewrites, logs_xml.config or *.cer files. Also promotes File changed message from DEBUG to ERROR for report mode.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Set up a test box with traffic_ops_ort. Badass an initial EDGE configuration with some DS's that contain EDGE header rewrite rules.
First test: Queue CDN. Run syncds, WARN mode. Old version the header_rewrite header file will trigger false positives. New version should not. Edit a DS's header rewrite rule, queue, run syncds. Only the edited header rewrite rule should update.
Next test: Edit header_rewrite for DS and queue. Run report mode with WARN mode. Ensure the changed accompanying header rewrite and only that one shows up as an ERROR message.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information