Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add labels to bandwidth chart tooltip#4376

Merged
mitchell852 merged 4 commits into
apache:masterfrom
shamrickus:1486
Feb 5, 2020
Merged

Add labels to bandwidth chart tooltip#4376
mitchell852 merged 4 commits into
apache:masterfrom
shamrickus:1486

Conversation

@shamrickus
Copy link
Copy Markdown
Member

@shamrickus shamrickus commented Feb 5, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

While on the dashboard, ensure that hovering over a point in the bandwidth line shows the correct units on bandwidth. Also ensure that the tooltip for the connections line is unaffected.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@ocket8888 ocket8888 added improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1 labels Feb 5, 2020
Comment thread traffic_portal/app/src/common/modules/widget/cdnChart/WidgetCDNChartController.js Outdated
@mitchell852 mitchell852 self-assigned this Feb 5, 2020
@mitchell852 mitchell852 merged commit a98a089 into apache:master Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TP - add Gbps label to CDN bandwidth chart tool tip

3 participants