This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Add support for TO_API_VERSION env var in to-access.sh#4429
Merged
ocket8888 merged 1 commit intoapache:masterfrom Feb 21, 2020
Merged
Add support for TO_API_VERSION env var in to-access.sh#4429ocket8888 merged 1 commit intoapache:masterfrom
ocket8888 merged 1 commit intoapache:masterfrom
Conversation
By default, make requests at 2.0 but allow overriding the version when necessary to deal with older TO servers.
Member
|
Do you think |
Contributor
Author
|
I don't think it would be required there. In general CIAB should just take the default version set in the script itself -- only users sourcing the script directly for non-CIAB purposes would care to set a specific version. |
mhoppa
approved these changes
Feb 21, 2020
Contributor
mhoppa
left a comment
There was a problem hiding this comment.
works in CDN box, works manually testing setting the API version to different versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
By default, make requests at 2.0 but allow overriding the version when
necessary to deal with older TO servers.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
With TO_URL, TO_USER, and TO_PASSWORD vars set appropriately:
. to-access.sh; to-auth-> verify that the login request was made to TO at API version 2.0.TO_API_VERSION=1.4; . to-access.sh; to-auth-> verify that the login request was made to TO at API version 1.4.Start up a Docker CIAB instance, make sure it all starts up properly as it depends on the
to-access.shscript.The following criteria are ALL met by this PR