This repository was archived by the owner on Nov 24, 2025. It is now read-only.
[Backport 4.0.x] Fix ort caching to JSON (#4433)#4435
Closed
rawlinp wants to merge 1 commit intoapache:4.0.xfrom
Closed
[Backport 4.0.x] Fix ort caching to JSON (#4433)#4435rawlinp wants to merge 1 commit intoapache:4.0.xfrom
rawlinp wants to merge 1 commit intoapache:4.0.xfrom
Conversation
ORT/atstccfg caching was Gob because it was the fastest option. Unfortunately, it's also broken. Gob is not isomorphic, resulting in wrong config files. See golang/go#4609 Also includes tests to verify the default format is isomorphic. Gob fails the test, CBOR and JSON pass. (cherry picked from commit 6e4bc2f)
rawlinp
added
bug
Contributor
Author
|
Whoops, didn't see #4434 -- closing as a duplicate backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4432 - this is an alternative to that PR, using JSON, which make an ORT run ~50% slower than CBOR, but doesn't require upgrading Go to 1.12. I'll let the community decide which to merge.
Fixes ORT caching to JSON. The current Gob encoding is fundamentally broken. See golang/go#4609 . It's not isomorphic: it does not decode what in encodes. In practical terms, default values like 0 become null pointers, resulting in missing remap lines in the config.
This changes the default to JSON.
It also adds a unit test, to verify the default cache format is isomorphic. Gob fails the test, CBOR and JSON pass it.
Includes tests. No docs, no changelog, no interface change.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run unit tests.
Generate remap.config with assigned delivery services of type "HTTP" (which is represented by
0, the default int value). Without this fix, remap lines will be missing. With fix, config file should have appropriate remap lines for HTTP DSes.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information