This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Rework riak/bucket/:bucket/key/:key/value#4464
Merged
mitchell852 merged 6 commits intoapache:masterfrom Mar 4, 2020
shamrickus:rw_riak
Merged
Rework riak/bucket/:bucket/key/:key/value#4464mitchell852 merged 6 commits intoapache:masterfrom shamrickus:rw_riak
mitchell852 merged 6 commits intoapache:masterfrom
shamrickus:rw_riak
Conversation
zrhoffman
suggested changes
Mar 4, 2020
zrhoffman
approved these changes
Mar 4, 2020
Member
zrhoffman
left a comment
There was a problem hiding this comment.
- Deprecation warning for the old route is there
- Unit tests pass (although no unit tests exist for the files modified)
- API tests pass (although there are no API tests for this endpoint)
*go fmtdoesn't correct anything from this PR - Docs build without any warnings from this PR
Looks good to merge.
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
The riak/bucket/:bucket/key/:key/value endpoint should be deprecated and replaced with vault/bucket/:bucket/key/:key/value with no functionality changes.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Pull the code, verify the docs build with no warnings. TO tests pass without issue. Finally, 1.1 route has a deprecation notice and the 2.0 route is moved to vault.
The following criteria are ALL met by this PR