This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TP: Format DNSSEC keys effectiveDate in RCF3339 format#4469
Merged
mitchell852 merged 2 commits intoapache:masterfrom Mar 6, 2020
Merged
TP: Format DNSSEC keys effectiveDate in RCF3339 format#4469mitchell852 merged 2 commits intoapache:masterfrom
mitchell852 merged 2 commits intoapache:masterfrom
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Currently, TP is formatting the effectiveDate field in the request as
unix epoch in MILLISECONDS. TO API expects epoch time format to be in
SECONDS. This means that TO creates DNSSEC keys with an effective date
ridiculously far into the future, when it was meant for the effective
date to be "now".
Alternatively, just format it as RFC3339, which the TO API can
also parse.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Without this PR installed, in Traffic Portal open the developer console and generate CDN DNSSEC keys. Verify that the
effectiveDatefield sent in the request to TO is formatted as a unix epoch time -- e.g."1583439180411".With the PR installed, do the same thing but verify the time is formatted in RFC3339 format -- e.g.
"2020-03-05T20:57:00Z".If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR