Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TP: Format DNSSEC keys effectiveDate in RCF3339 format#4469

Merged
mitchell852 merged 2 commits intoapache:masterfrom
rawlinp:fix-tp-dnssec-bug
Mar 6, 2020
Merged

TP: Format DNSSEC keys effectiveDate in RCF3339 format#4469
mitchell852 merged 2 commits intoapache:masterfrom
rawlinp:fix-tp-dnssec-bug

Conversation

@rawlinp
Copy link
Contributor

@rawlinp rawlinp commented Mar 5, 2020

What does this PR (Pull Request) do?

Currently, TP is formatting the effectiveDate field in the request as
unix epoch in MILLISECONDS. TO API expects epoch time format to be in
SECONDS. This means that TO creates DNSSEC keys with an effective date
ridiculously far into the future, when it was meant for the effective
date to be "now".

Alternatively, just format it as RFC3339, which the TO API can
also parse.

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Without this PR installed, in Traffic Portal open the developer console and generate CDN DNSSEC keys. Verify that the effectiveDate field sent in the request to TO is formatted as a unix epoch time -- e.g. "1583439180411".

With the PR installed, do the same thing but verify the time is formatted in RFC3339 format -- e.g. "2020-03-05T20:57:00Z".

If this is a bug fix, what versions of Traffic Control are affected?

  • master
  • 4.0.x

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • Bugfix, no docs necessary
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants