optimization debian package manager tweaks by rajpratik71 · Pull Request #4474 · apache/trafficcontrol

rajpratik71 · 2020-03-10T13:47:05Z

What does this PR (Pull Request) do?

This PR is not related to any Issue

By default, Ubuntu-based or Debian-based apt or apt-get system installs recommended - but not suggested - packages .

By passing --no-install-recommends"\ option, the user lets apt-get know not to consider recommended packages as a dependency to install.

This results in smaller downloads and installation of packages .

Refer to blog at Ubuntu Blog .

This PR inserts this option into calls to apt/apt-get in various places throughout the code base.

Which Traffic Control components are affected by this PR?

CDN in a Box
Documentation

What is the best way to verify this PR?

Build documentation and build and run affected Docker image specifications.

The following criteria are ALL met by this PR

Only affects dependency management; building/running is the only testing that makes sense.
This PR includes documentation
An update to CHANGELOG.md is not necessary
This PR includes any and all required license headers
This PR does not include a database migration
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

By default, Ubuntu or Debian based "apt" or "apt-get" system installs recommended but not suggested packages . By passing "--no-install-recommends" option, the user lets apt-get know not to consider recommended packages as a dependency to install. This results in smaller downloads and installation of packages . Refer to blog at [Ubuntu Blog](https://ubuntu.com/blog/we-reduced-our-docker-images-by-60-with-no-install-recommends) . Signed-off-by: Pratik Raj <rajpratik71@gmail.com>

ocket8888 · 2020-03-10T17:21:11Z

docs/source/admin/quick_howto/ciab.rst

 	:caption: Install openvpn on ubuntu/debian

-	apt-get update && apt-get install -y openvpn
+	apt-get update && apt-get --no-install-recommends install -y openvpn


This is just for people to install a vpn client on the host, so I don't think there's any need for this.

I general updated "apt-get install" with "apt-get --no-install-recommends install" as a best practice for apt-get wherever applicable

Right, but in this case the user is installing something on their own computer. --no-install-recommends is a "best practice" for the context of docker, but ostensibly the user has the default apt configuration they want on their own host computer. We don't need to worry - and shouldn't worry - about policing that.

ocket8888 · 2020-03-10T17:21:28Z

infrastructure/cdn-in-a-box/optional/vpn/README.rst

 .. code-block:: shell

-    apt-get update && apt-get install -y openvpn
+    apt-get update && apt-get --no-install-recommends install -y openvpn


Same as above

I general updated "apt-get install" with "apt-get --no-install-recommends install" as a best practice for apt-get wherever applicable , doesn't have any issue and didn't looked for specific use case

Agree with @ocket8888—We're not in the business of policing a user's own APT configuration.

ocket8888 · 2020-03-11T19:30:58Z

docs/source/admin/traffic_vault.rst


 		# On Ubuntu/Debian/Linux Mint
-		apt install -y openjdk-8-jdk
+		apt-get --no-install-recommends install -y openjdk-8-jdk


Same as above RE: user install recommendations.

zrhoffman · 2020-04-20T14:08:28Z

infrastructure/cdn-in-a-box/dns/Dockerfile

 && echo 'APT::Install-Suggests 0;' >> /etc/apt/apt.conf.d/01norecommends \
 && apt-get update \
- && DEBIAN_FRONTEND=noninteractive apt-get install -y vim.tiny wget net-tools sudo net-tools ca-certificates unzip apt-transport-https \
+ && DEBIAN_FRONTEND=noninteractive apt-get --no-install-recommends install -y vim.tiny wget net-tools sudo net-tools ca-certificates unzip apt-transport-https \


The lines above

RUN echo 'APT::Install-Recommends 0;' >> /etc/apt/apt.conf.d/01norecommends \ && echo 'APT::Install-Suggests 0;' >> /etc/apt/apt.conf.d/01norecommends \

updating the APT config to skip package recommendations, so there is no need to pass the --no-install-recommends option with every apt or apt-get command.

zrhoffman · 2020-04-20T14:10:13Z

infrastructure/cdn-in-a-box/dns/Dockerfile

 && rm -rf /var/lib/apt/lists/* && rm -rf /etc/apt/apt.conf.d/docker-gzip-indexes \
 && apt-get update \
- && DEBIAN_FRONTEND=noninteractive apt-get install -y bind9=${BIND_VERSION}* bind9-host=${BIND_VERSION}* dnsutils \
+ && DEBIAN_FRONTEND=noninteractive apt-get --no-install-recommends install -y bind9=${BIND_VERSION}* bind9-host=${BIND_VERSION}* dnsutils \


Same as above—We already disable APT::Install-Recommends in the APT configuration in this Dockerfile, so no need to pass the --no-install-recommends CLI option.

zrhoffman · 2020-04-20T14:12:50Z

infrastructure/cdn-in-a-box/enroller/Dockerfile

 FROM debian:stretch

-RUN apt-get update && apt-get install -y netcat curl dnsutils net-tools && apt-get clean
+RUN apt-get update && apt-get --no-install-recommends install -y netcat curl dnsutils net-tools && apt-get clean


See above—I would prefer disabling APT::Install-Recommends and APT::Install-Suggests in the APT configuration to passing --no-install-recommends for every apt or apt-get command.

zrhoffman · 2020-04-20T14:28:57Z

infrastructure/cdn-in-a-box/traffic_vault/Dockerfile

 && echo 'APT::Install-Suggests 0;' >> /etc/apt/apt.conf.d/01norecommends \
 && apt-get update \
- && DEBIAN_FRONTEND=noninteractive apt-get install -y net-tools ca-certificates dnsutils gettext-base \
+ && DEBIAN_FRONTEND=noninteractive apt-get --no-install-recommends install -y net-tools ca-certificates dnsutils gettext-base \


As with the dns Dockerfile,

RUN echo 'APT::Install-Recommends 0;' >> /etc/apt/apt.conf.d/01norecommends \ && echo 'APT::Install-Suggests 0;' >> /etc/apt/apt.conf.d/01norecommends \

already updates the APT config to skip package recommendations, so there is no need to pass the --no-install-recommends option with every apt or apt-get command.

zrhoffman · 2020-04-20T14:31:30Z

traffic_portal/Dockerfile

 #FROM buildpack-deps:jessie

-RUN apt-get update -y && apt-get install libffi-dev ruby-dev rubygems vim -y
+RUN apt-get update -y && apt-get --no-install-recommends install -y libffi-dev ruby-dev rubygems vim -y


See above—I would prefer disabling APT::Install-Recommends and APT::Install-Suggests in the APT configuration to passing --no-install-recommends for every apt or apt-get command.

zrhoffman · 2020-04-20T14:32:24Z

infrastructure/cdn-in-a-box/traffic_stats/Dockerfile-influxdb


 RUN apt-get update && \
-    apt-get install -y dnsutils net-tools gettext-base netcat && \
+    apt-get --no-install-recommends install -y dnsutils net-tools gettext-base netcat && \


See above—I would prefer disabling APT::Install-Recommends and APT::Install-Suggests in the APT configuration to passing --no-install-recommends for every apt or apt-get command.

zrhoffman · 2020-04-20T14:33:31Z

infrastructure/cdn-in-a-box/optional/vpn/Dockerfile


 FROM ubuntu:18.04
-RUN apt-get update && apt-get install -y vim tree wget iptables openvpn iputils-ping net-tools dnsutils
+RUN apt-get update && apt-get --no-install-recommends install -y vim tree wget iptables openvpn iputils-ping net-tools dnsutils


See above—I would prefer disabling APT::Install-Recommends and APT::Install-Suggests in the APT configuration to passing --no-install-recommends for every apt or apt-get command.

zrhoffman · 2020-04-20T14:33:35Z

infrastructure/cdn-in-a-box/optional/grafana/Dockerfile


 RUN apt-get update && \
-    apt-get install -y dnsutils net-tools gettext-base p7zip-full netcat && \
+    apt-get --no-install-recommends install -y dnsutils net-tools gettext-base p7zip-full netcat && \


See above—I would prefer disabling APT::Install-Recommends and APT::Install-Suggests in the APT configuration to passing --no-install-recommends for every apt or apt-get command.

zrhoffman · 2020-04-20T14:34:57Z

infrastructure/cdn-in-a-box/optional/vpn/README.rst

 .. code-block:: shell

-    apt-get update && apt-get install -y openvpn
+    apt-get update && apt-get --no-install-recommends install -y openvpn


Agree with @ocket8888—We're not in the business of policing a user's own APT configuration.

zrhoffman · 2020-04-20T14:35:21Z

experimental/postgrest/Postgrest_Dockerfile

 MAINTAINER dev@trafficcontrol.apache.org

-RUN apt-get install -y curl tar xz-utils postgresql-client
+RUN apt-get --no-install-recommends install -y curl tar xz-utils postgresql-client


I would prefer disabling APT::Install-Recommends and APT::Install-Suggests in the APT configuration to passing --no-install-recommends for every apt or apt-get command.

ocket8888 · 2021-04-13T17:03:06Z

closing as stale with conflicts; please re-base and re-open or open a new PR to get these changes merged.

ocket8888 reviewed Mar 10, 2020

View reviewed changes

rajpratik71 requested a review from ocket8888 March 11, 2020 14:31

ocket8888 self-assigned this Mar 11, 2020

ocket8888 reviewed Mar 11, 2020

View reviewed changes

zrhoffman suggested changes Apr 20, 2020

View reviewed changes

ocket8888 closed this Apr 13, 2021

Conversation

rajpratik71 commented Mar 10, 2020 • edited by ocket8888 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

The following criteria are ALL met by this PR

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocket8888 commented Apr 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rajpratik71 commented Mar 10, 2020 •

edited by ocket8888

Loading