Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Collapse cdns/{{ID}}/snapshot & snapshot/{{CDN}} to snapshot route#4517

Merged
mattjackson220 merged 6 commits intoapache:masterfrom
mhoppa:feature/rework_cdn_snapshot
Mar 25, 2020
Merged

Collapse cdns/{{ID}}/snapshot & snapshot/{{CDN}} to snapshot route#4517
mattjackson220 merged 6 commits intoapache:masterfrom
mhoppa:feature/rework_cdn_snapshot

Conversation

@mhoppa
Copy link
Contributor

@mhoppa mhoppa commented Mar 18, 2020

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Deprecates both PUT cdns/{{ID}}/snapshot & PUT snapshot/{{CDN}} and makes a new endpoint snapshot in 2.0 that replaces both with query parameters

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Run traffic ops and make sure you can not hit the endpoints PUT cdns/{{ID}}/snapshot & PUT snapshot/{{CDN}} in API 2.0 and when performing a PUT on the, in 1.x you receive a deprecation message back in the returned alerts. .

Make requests to PUT /snapshot route with query parameters cdn and cdnID and ensure it works.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@mitchell852 mitchell852 added documentation related to documentation Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution labels Mar 19, 2020
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • TO unit/integration tests pass
  • No go fmt issues
  • Endpoint collapsed into one
  • No docs issues
  • All references in ORT/client updated

@mattjackson220 mattjackson220 merged commit 96769b6 into apache:master Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation related to documentation tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants