This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Collapse cdns/{{ID}}/snapshot & snapshot/{{CDN}} to snapshot route#4517
Merged
mattjackson220 merged 6 commits intoapache:masterfrom Mar 25, 2020
Merged
Collapse cdns/{{ID}}/snapshot & snapshot/{{CDN}} to snapshot route#4517mattjackson220 merged 6 commits intoapache:masterfrom
mattjackson220 merged 6 commits intoapache:masterfrom
Conversation
shamrickus
suggested changes
Mar 23, 2020
shamrickus
approved these changes
Mar 24, 2020
Member
shamrickus
left a comment
There was a problem hiding this comment.
LGTM
- TO unit/integration tests pass
- No
go fmtissues - Endpoint collapsed into one
- No docs issues
- All references in ORT/client updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Deprecates both
PUTcdns/{{ID}}/snapshot &PUTsnapshot/{{CDN}} and makes a new endpoint snapshot in 2.0 that replaces both with query parametersWhich Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run traffic ops and make sure you can not hit the endpoints
PUTcdns/{{ID}}/snapshot &PUTsnapshot/{{CDN}} in API 2.0 and when performing a PUT on the, in 1.x you receive a deprecation message back in the returned alerts. .Make requests to
PUT/snapshot route with query parameterscdnandcdnIDand ensure it works.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information