Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Rework /deliveryservice_server/:dsid/:serverid#4520

Merged
mattjackson220 merged 4 commits intoapache:masterfrom
mhoppa:feature/rework_deliveryservice_server
Mar 25, 2020
Merged

Rework /deliveryservice_server/:dsid/:serverid#4520
mattjackson220 merged 4 commits intoapache:masterfrom
mhoppa:feature/rework_deliveryservice_server

Conversation

@mhoppa
Copy link
Copy Markdown
Contributor

@mhoppa mhoppa commented Mar 18, 2020

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Deprecates DELETE /deliveryservice_server/:dsid/:serverid and makes a new endpoint DELETE /deliveryserviceserver/:dsid/:serverid in 2.0 that replaces the functionality

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Run traffic ops and make sure you can not hit the endpoint DELETE /deliveryservice_server/:dsid/:serverid in API 2.0 and when performing a DELETE on it in 1.x you receive a deprecation message back in the returned alerts. .

Make requests to DELETE /deliveryserviceserver/:dsid/:serverid and ensure it works.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution documentation related to documentation labels Mar 19, 2020
Comment thread traffic_ops/traffic_ops_golang/deliveryservice/servers/delete.go Outdated
Copy link
Copy Markdown
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • TO unit/integration tests pass
  • No go fmt issues
  • deliveryservice_server/... is gone in 2.0 and deprecated in 1.1
  • deliveryservicesserver/... works the same as the old 1.1 version
  • No docs issues
  • All references in ORT/client/TP updated
  • TP tests pass

@mattjackson220 mattjackson220 merged commit 53cf941 into apache:master Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation related to documentation tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants