This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix atscfg ip_allow gen not using v6 number param#4678
Merged
Conversation
rob05c
added
bug
rawlinp
approved these changes
May 1, 2020
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
Unit tests pass, no longer seeing the erroneous warning when running atstccfg
Contributor
|
Oh, there is a merge conflict with CHANGELOG.md -- @rob05c once you rebase I will merge this. |
rob05c
force-pushed
the
fix-atscfg-ipallow-wrong-var
branch
from
5ec5cf2 to
bd3d76b
Compare
Member
Author
|
Rebased |
rawlinp
pushed a commit
to rawlinp/trafficcontrol
that referenced
this pull request
May 28, 2020
(cherry picked from commit 228371c)
rawlinp
added a commit
that referenced
this pull request
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Fixes ORT config generation not using the
coalesce_number_v6Parameter.Includes tests.
No docs, no interface change.
Includes changelog.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run unit tests.
Run ORT against a Traffic Ops with a custom
coalesce_number_v6parameter, verify the generated ip_allow.config IPv6 addresses are collapsed according to the Parameter and not the default of 5.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information