This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Improve content invalidation audit logging#4689
Merged
mattjackson220 merged 2 commits intoMay 13, 2020
Merged
Conversation
When this API was rewritten to Go, the audit logging was made too terse. Improve it to provide as much information as TO-Perl provided.
rawlinp
added
Traffic Ops
zrhoffman
approved these changes
May 13, 2020
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
This looks good to me. API and unit tests pass, and the changes are a definite improvement to logging.
rawlinp
added a commit
to rawlinp/trafficcontrol
that referenced
this pull request
May 28, 2020
* Improve content invalidation audit logging When this API was rewritten to Go, the audit logging was made too terse. Improve it to provide as much information as TO-Perl provided. * Add changelog entry (cherry picked from commit 436b046)
rawlinp
added a commit
that referenced
this pull request
May 28, 2020
* Improve content invalidation audit logging When this API was rewritten to Go, the audit logging was made too terse. Improve it to provide as much information as TO-Perl provided. * Add changelog entry (cherry picked from commit 436b046)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
When this API was rewritten to Go, the audit logging was made too terse.
Improve it to provide as much information as TO-Perl provided.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Create a content invalidation job, update it, then delete it. Observe the created audit log messages in TP and verify that they provide sufficient information (DS xml_id, asset URL, params).
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR