This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix MaxRevalDurationDays validation for invalidation jobs#4718
Merged
ocket8888 merged 4 commits intoapache:masterfrom May 27, 2020
Merged
Fix MaxRevalDurationDays validation for invalidation jobs#4718ocket8888 merged 4 commits intoapache:masterfrom
ocket8888 merged 4 commits intoapache:masterfrom
Conversation
Member
|
Branch has a merge conflict in the changelog |
Contributor
Author
|
Thanks! Merge conflict resolved. |
zrhoffman
suggested changes
May 26, 2020
zrhoffman
suggested changes
May 26, 2020
zrhoffman
approved these changes
May 27, 2020
Member
zrhoffman
left a comment
There was a problem hiding this comment.
- API tests pass
gofmtis happy with the added code- Code looks good
👍
rawlinp
added a commit
to rawlinp/trafficcontrol
that referenced
this pull request
May 28, 2020
* Fix MaxRevalDurationDays validation for invalidation jobs * Address review feedback * unindent (cherry picked from commit 94e4ede)
rawlinp
added a commit
that referenced
this pull request
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Fix the validation of invalidation job TTLs per the
maxRevalDurationsDaysparameter. The broken validation was not converting days to hours before doing the validation. This PR also adds that validation to the/jobsendpoints because it was missing.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the unit tests and TO API tests. Verify they pass. Manually
POST /api/1.4/user/current/jobswith a ttl that higher than the value of themaxRevalDurationDaysparameter (x 24). Example request json below:If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR