This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Queries with invalid type parameter should return 400s, not 500s#4721
Merged
mattjackson220 merged 6 commits intoapache:masterfrom Jun 1, 2020
Merged
Queries with invalid type parameter should return 400s, not 500s#4721mattjackson220 merged 6 commits intoapache:masterfrom
mattjackson220 merged 6 commits intoapache:masterfrom
Conversation
ocket8888
reviewed
May 26, 2020
Contributor
|
one small change to the test and this looks good to me! unit and API tests pass, code looks good, go fmt is happy, works as expected. nice work! |
mattjackson220
added
bug
Contributor
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Setup TO locally and make a query like this
GET /api/3.0/cachegroups?type=WRONGThis should return a 400, with the error details in it as the response.
If this is a bug fix, what versions of Traffic Control are affected?
master
The following criteria are ALL met by this PR
Additional Information