[Backport #4683] Remove audit logging from POST /serverchecks endpoint

CHANGELOG.md

@@ -59,6 +59,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Fix to traffic_ops_ort to generate logging.yaml files correctly.
 - Fixed issue #4650: add the "Vary: Accept-Encoding" header to all responses from Traffic Ops
 - Fixed ORT config generation not using the coalesce_number_v6 Parameter.
+- Removed audit logging from the `POST /api/x/serverchecks` Traffic Ops API endpoint in order to reduce audit log spam
 
 ### Deprecated/Removed
 - The Traffic Ops `db/admin.pl` script has now been removed. Please use the `db/admin` binary instead.

traffic_ops/traffic_ops_golang/servercheck/servercheck.go

@@ -149,9 +149,9 @@ func CreateUpdateServercheck(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	successMsg := "Server Check was successfully updated"
-	api.CreateChangeLogRawTx(api.ApiChange, successMsg, inf.User, inf.Tx.Tx)
-	api.WriteRespAlert(w, r, tc.SuccessLevel, successMsg)
+	// NOTE: this endpoint does not create an audit log entry in order to prevent
+	//       spamming the audit log with thousands of entries every minute
+	api.WriteRespAlert(w, r, tc.SuccessLevel, "Server Check was successfully updated")
 }
 
 func getServerID(id *int, hostname *string, tx *sql.Tx) (int, bool, error) {