This repository was archived by the owner on Nov 24, 2025. It is now read-only.
[BACKPORT #4707] Add and satisfy OptionsDelete API test for DELETE /regions?name={{name}}#4732
Merged
Merged
Conversation
…e}} (apache#4707) * Add an API test for DELETE /regions?name={{name}} * No changelog entry * Combine OptionsDeleter and HasDeleteKeyOptions interfaces Rename variables: - hasDeleteKeyOption() -> checkIfOptionsDeleter() - deleteKeyOptionsExists isOptionsDeleter * Do not bail if the type is an options deleter * Add new DeleteHandler() logic to DeprecatedDeleteHandler() * Remove unnecessary "else" clause * Add "name" param to GetKeys() and SetKeys() * Set object keys from DeleteKeyOptions() or GetKeyFieldsInfo() depending on whether the object is an options deleter * Add audit log assertions to the API test for deleting a region by name * No need to return "name" param from GetKeys() * DeprecatedDeleteHandler: Set object keys from DeleteKeyOptions() or GetKeyFieldsInfo() depending on whether the object is an options deleter * kf.Field -> key (cherry picked from commit 56d09e6)
rawlinp
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #4707 to 4.1.x.