Tp interface servers by ocket8888 · Pull Request #4747 · apache/trafficcontrol

ocket8888 · 2020-06-01T22:34:59Z

What does this PR (Pull Request) do?

This PR fixes Update Traffic Portal to account for new response/request structures for /servers #4623 and fixes Strange API behavior on add server via UI #4792

Updates Traffic Portal tables and forms to account for servers having multiple interfaces, including:

any table that shows servers obtained from /servers such as
- Servers
- Cache Groups -> View Servers
- Profiles -> View Servers
- Delivery Services -> View Servers
The server create/edit form

Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?

Build Traffic Portal, verify that all the mentioned tables and forms work properly.
Run the TP integration tests.
You could also run the UI tests, but I think they're broken on master atm [citation needed], so I'll need to look into that.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

This PR includes tests OR I have explained why tests are unnecessary
This PR includes documentation OR I have explained why documentation is unnecessary
This PR includes an update to CHANGELOG.md OR such an update is not necessary
This PR includes any and all required license headers
This PR ensures that database migration sequence is correct OR this PR does not include a database migration
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

mitchell852 · 2020-06-10T18:52:29Z

@ocket8888 - do you want to move the The ISO generation form part into it's own PR to keep this PR focused?

ocket8888 · 2020-06-10T18:56:58Z

I suppose I can. Working on something else atm, though, so it might be a bit.

ocket8888 · 2020-06-10T23:29:30Z

Done

mitchell852

A few things:

offline reason label looks screwed up:

how about putting some words on these buttons rather than + and - so you don't have to hover over the button to figure out what it's for:

how about moving the interfaces section to the bottom of the form rather than putting it between profile and phys location?

...ic_portal/app/src/common/modules/table/cacheGroupServers/TableCacheGroupServersController.js

mitchell852

getting errors on the server create page - https://tp.domain.com/#!/servers/new

first error:

TypeError: Cannot read property 'cdnId' of undefined
at init (FormServerController.js:205)

mitchell852

some more feedback

...ic_portal/app/src/common/modules/table/cacheGroupServers/TableCacheGroupServersController.js

traffic_portal/app/src/common/modules/table/cdnServers/TableCDNServersController.js

...ortal/app/src/common/modules/table/physLocationServers/TablePhysLocationServersController.js

traffic_portal/app/src/common/modules/table/profileServers/TableProfileServersController.js

traffic_portal/app/src/common/modules/table/statusServers/TableStatusServersController.js

traffic_portal/app/src/common/modules/table/typeServers/TableTypeServersController.js

mitchell852 · 2020-06-15T20:54:35Z

traffic_portal/app/src/common/modules/form/server/form.server.tpl.html

when you add your first interface, it's unclear what to put in the first box

What should I do about that? Add a placeholder or a label? I thought using the name as the full legend was pretty neat, looked a little weird with "Name: " in front of everything.

placeholder would be fine. i just think it will confuse people. maybe placeholder: name (i.e. eth0, bond0, etc)

placeholders are only supposed to be example values that would be valid in the input if you typed them in. So I added a placeholder, lemme know if you think that works.

ocket8888 · 2020-06-15T21:56:34Z

I'm not seeing any errors on the server create page. Tried Chrome and Firefox.

mitchell852 · 2020-06-22T19:12:44Z

I like the way you've nested the interfaces on the form, but i'm still have a hard time visually lining up the buttons with the proper nested box and the interface buttons are interfering with the main buttons of the form as well (update/delete).

what about moving a button or a link into the legend like such:

mitchell852 · 2020-06-22T19:15:16Z

also, i'm getting this error when trying to create a server:

shared-libs.js:65171 TypeError: Cannot read property 'cdnId' of undefined

mitchell852 · 2020-06-22T20:49:59Z

traffic_portal/app/src/common/modules/form/server/form.server.tpl.html

+                <legend>Interfaces<button class="btn btn-success right-button" type="button" title="add a new interface" ng-click="addInterface()">Add Interface</button></legend>
+                <fieldset ng-repeat="inf in server.interfaces">
+                    <legend>
+                        <input my-directive type="text" ng-model="inf.name" required aria-label="Interface name" id="{{inf.name}}-name" name="{{inf.name}}-name" ng-class="{'has-error': hasError(serverForm[inf.name+'-name'])}" placeholder="eth0"/>


my-directive?

this text input acts weird for me. does it for you? i can only put my cursor at the start of the text.

idk what "my-directive" is or why it's in there. I'll get rid of it.
as far as "acting weird," no, I don't think I have noticed that, but I'll look at it.

directive is gone, can't reproduce not being allowed to put your cursor wherever you want

oh, i understand what is going on

eth0 is a placeholder. it looks like regular text so i was trying to double click it to select it all to replace it...

maybe the placeholder was a bad idea because now it looks like text and the update or create button is disabled unless i change it....but if i want it to be eth0 it looks like it's already filled in. maybe a better placeholder would be interface-name?

That could work.

ocket8888 · 2020-06-22T22:38:54Z

also, i'm getting this error when trying to create a server:

shared-libs.js:65171 TypeError: Cannot read property 'cdnId' of undefined

fixed

mitchell852 · 2020-06-23T14:46:05Z

If you put your buttons in the legend, i think the icon buttons (like you had originally) work pretty well instead of the words. looks cleaner

for example:

<legend>Interfaces<a title="add a new interface" class="btn btn-primary btn-xs pull-right" ng-click="addInterface()"><i class="fa fa-plus"></i></a></legend>

mitchell852 · 2020-06-23T15:59:48Z

I created a PR for you if you want to show the success/error message in a more friendly way

ocket8888#36

ocket8888 · 2020-06-23T17:24:35Z

Buttons are back to +/-

mitchell852 · 2020-06-24T18:42:22Z

@ocket8888 - doesn't every cache require at least one service address? I can create one w/o a service address.

mitchell852 · 2020-06-24T18:45:28Z

I added the 42 to an existing interface and the Update button did not enable:

… of form on success/error

mitchell852 · 2020-06-26T20:15:30Z

ocket8888#38

mitchell852 · 2020-06-26T20:17:55Z

also, getting this error when trying to update status on a server:

@ocket8888 did you look at this one?

actually, just apply this @ocket8888 - mitchell852@e0f33ad - i tried to PR your PR but it got all screwed up.

mitchell852 · 2020-06-28T23:13:15Z

"I can create one w/o a service address."

No you can't. You can try, but it's not possible.

No, I did. It was possible. :)

ok, this is fixed now with #4828

…ntrol into tp-interface-servers

mitchell852

UI tests pass. did a bunch of manual testing. everything seems to work as expected. nice work!

mitchell852 · 2020-06-30T02:45:03Z

retest this please

ocket8888 force-pushed the tp-interface-servers branch 2 times, most recently from aaf175c to 39401fe Compare June 9, 2020 18:39

ocket8888 added improvement The functionality exists but it could be improved in some way. medium impact impacts a significant portion of a CDN, or has the potential to do so Traffic Portal v1 related to Traffic Portal version 1 labels Jun 9, 2020

ocket8888 marked this pull request as ready for review June 9, 2020 19:08

ocket8888 mentioned this pull request Jun 10, 2020

Servers table switch to ag-grid #4769

Merged

7 tasks

ocket8888 force-pushed the tp-interface-servers branch from 39401fe to bef4eb3 Compare June 10, 2020 23:20

mitchell852 suggested changes Jun 12, 2020

View reviewed changes

mitchell852 reviewed Jun 12, 2020

View reviewed changes

...ic_portal/app/src/common/modules/table/cacheGroupServers/TableCacheGroupServersController.js Outdated Show resolved Hide resolved

ocket8888 mentioned this pull request Jun 14, 2020

Strange API behavior on add server via UI #4792

Closed

mitchell852 suggested changes Jun 15, 2020

View reviewed changes

ocket8888 force-pushed the tp-interface-servers branch from 1f321a4 to d285f33 Compare June 15, 2020 21:49

ocket8888 force-pushed the tp-interface-servers branch 2 times, most recently from 0dc19f9 to c099126 Compare June 17, 2020 21:18

ocket8888 force-pushed the tp-interface-servers branch from c099126 to f242110 Compare June 22, 2020 19:56

mitchell852 reviewed Jun 22, 2020

View reviewed changes

ocket8888 and others added 14 commits June 25, 2020 15:17

Replaced button symbols with words

9dabd60

Moved interfaces to bottom of servers form

59365ff

Removed duplicated map

9a68178

Removed more duplicated maps

29c5931

Fixed Offline Reason field

6f9c928

Removed unused injections

37bfa91

Fixed servers table not displaying legacy interface data properly

6bd9c2b

Moved add/remove interface/ip buttons

c75fb58

Added placeholders

f7423a8

Fixed error creating new server

d9cdb77

moves actions into the caller for more control and scrolls to the top…

2ad1c57

… of form on success/error

Switched to smaller buttons; made interface placeholder more clear

041733f

fixes server that is now an array of servers

78dcf5a

Fixed setting max-bandwidth not dirtying the form

801417e

ocket8888 force-pushed the tp-interface-servers branch from b44054d to 801417e Compare June 25, 2020 22:32

fixes server config files table

ec83b40

ocket8888 and others added 3 commits June 29, 2020 14:50

Fixed broken update server status

feca5cb

Merge branch 'tp-interface-servers' of github.com:ocket8888/trafficco…

7472e24

…ntrol into tp-interface-servers

fixes TP server tests to work with new server form

321b48d

mitchell852 approved these changes Jun 30, 2020

View reviewed changes

mitchell852 merged commit 78e4b00 into apache:master Jun 30, 2020

ocket8888 deleted the tp-interface-servers branch June 30, 2020 04:50

This was referenced Jul 6, 2020

[TC-378] "Network Subnet" server configuration, actually expects a netmask #1024

Closed

Cannot add a server capability to a server in TP #4853

Closed

Cannot assign delivery services to a server in TP #4858

Closed

ocket8888 mentioned this pull request Aug 13, 2020

Update Traffic Portal to account for new response/request structures for /deliveryservices/{{ID}}/servers #4624

Closed

Conversation

ocket8888 commented Jun 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

Uh oh!

mitchell852 commented Jun 10, 2020

Uh oh!

ocket8888 commented Jun 10, 2020

Uh oh!

ocket8888 commented Jun 10, 2020

Uh oh!

mitchell852 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mitchell852 left a comment

Choose a reason for hiding this comment

Uh oh!

mitchell852 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mitchell852 Jun 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitchell852 Jun 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocket8888 commented Jun 15, 2020

Uh oh!

mitchell852 commented Jun 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mitchell852 commented Jun 22, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocket8888 Jun 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocket8888 commented Jun 22, 2020

Uh oh!

mitchell852 commented Jun 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mitchell852 commented Jun 23, 2020

Uh oh!

ocket8888 commented Jun 23, 2020

Uh oh!

mitchell852 commented Jun 24, 2020

Uh oh!

mitchell852 commented Jun 24, 2020

Uh oh!

mitchell852 commented Jun 26, 2020

ocket8888 commented Jun 1, 2020 •

edited

Loading

mitchell852 Jun 15, 2020 •

edited

Loading

mitchell852 Jun 22, 2020 •

edited

Loading

mitchell852 commented Jun 22, 2020 •

edited

Loading

ocket8888 Jun 22, 2020 •

edited

Loading

mitchell852 commented Jun 23, 2020 •

edited

Loading

mitchell852 commented Jun 26, 2020 •

edited

Loading