Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@zrhoffman
Copy link
Member

What does this PR (Pull Request) do?

The FFI gem updated to version 1.13.0 yesterday, which included raising the minimum Ruby version to 2.3, which is higher than the version that CentOS 7 provides by default (2.0).

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Portal
  • Build Environment

What is the best way to verify this PR?

In the build docker-compose.yml:

Run pkg -v traffic_portal_build and verify that the expected Traffic Portal RPMs are produced

If this is a bug fix, what versions of Traffic Control are affected?

  • master (deadd96)
  • 4.0.0
  • 4.1.0 (RC1)

The following criteria are ALL met by this PR

  • Build environment has no tests
  • This PR includes documentation in the form of comments
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@mitchell852 mitchell852 self-assigned this Jun 2, 2020
@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 build related to the build process 4.1.x-backport-candidate labels Jun 2, 2020
Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. TP RPM built w/ no problems. I will merge once the auto checks are complete.

@mitchell852 mitchell852 merged commit a7fca2d into apache:master Jun 2, 2020
@zrhoffman zrhoffman deleted the pin-ffi-gem branch June 2, 2020 17:21
rawlinp pushed a commit to rawlinp/trafficcontrol that referenced this pull request Jun 10, 2020
rawlinp added a commit that referenced this pull request Jun 10, 2020
(cherry picked from commit a7fca2d)

Co-authored-by: Zach Hoffman <zach@zrhoffman.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

build related to the build process Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants