Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

POST deliveryservices/request - deep caching type and routing name are optional#4756

Merged
rawlinp merged 1 commit into
apache:masterfrom
mitchell852:dsr-optional-fields
Jun 4, 2020
Merged

POST deliveryservices/request - deep caching type and routing name are optional#4756
rawlinp merged 1 commit into
apache:masterfrom
mitchell852:dsr-optional-fields

Conversation

@mitchell852
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 commented Jun 3, 2020 •
edited
Loading

What does this PR (Pull Request) do?

deepcachingtype and routingname are now defined as optional for the email version of deliveryservice request

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run the API tests
Perform a POST to 1.4/deliveryservices/request minus deepcachingtype and routingname as required per https://traffic-control-cdn.readthedocs.io/en/latest/api/v1/deliveryservices_request.html#post and ensure the post succeeds.

If this is a bug fix, what versions of Traffic Control are affected?

  • master
  • 4.0.0
  • 4.1.0 (RC1)

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 mentioned this pull request Jun 3, 2020
Closed
7 tasks
@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops bug something isn't working as intended regression bug a bug in existing functionality introduced by a new version labels Jun 3, 2020
@mitchell852 mitchell852 marked this pull request as ready for review June 3, 2020 16:13
@mitchell852 mitchell852 requested a review from ocket8888 June 4, 2020 16:47
@mitchell852 mitchell852 force-pushed the dsr-optional-fields branch from f73329d to 4590fae Compare June 4, 2020 19:17
@rawlinp rawlinp merged commit 7fe31fa into apache:master Jun 4, 2020
rawlinp pushed a commit to rawlinp/trafficcontrol that referenced this pull request Jun 10, 2020
@mitchell852 @rawlinp
deep caching type and routing name are optional (apache#4756)
a28e42c 
(cherry picked from commit 7fe31fa)
@rawlinp rawlinp mentioned this pull request Jun 10, 2020
Merged
rawlinp added a commit that referenced this pull request Jun 10, 2020
@rawlinp @mitchell852
deep caching type and routing name are optional (#4756) (#4778)
bfd83c6 
(cherry picked from commit 7fe31fa)

Co-authored-by: Jeremy Mitchell <mitchell852@users.noreply.github.com>
@mitchell852 mitchell852 removed the bug something isn't working as intended label Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ocket8888 ocket8888 Awaiting requested review from ocket8888

1 more reviewer

@rawlinp rawlinp rawlinp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

POST deliveryservices/request requires deepcachingtype and routingname

2 participants

@mitchell852 @rawlinp