Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Updated to weasel v0.4.#4760

Merged
dneuman64 merged 1 commit into
apache:masterfrom
alficles:weasel-v0.4
Jun 4, 2020
Merged

Updated to weasel v0.4.#4760
dneuman64 merged 1 commit into
apache:masterfrom
alficles:weasel-v0.4

Conversation

@alficles
Copy link
Copy Markdown
Contributor

@alficles alficles commented Jun 4, 2020

This version has a number of feature improvements, including the ability to tag
files directly with SPDX-License-Identifier fields so they are properly
identified even if they move and will recognize a .gitignore file even if the
directory is not a git work tree. This is important for running weasel on
released tarballs.

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Documentation
  • Grove
  • Traffic Control Client (all)
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault

This is a simple update for weasel to fix an issue that occurs when you run against a tarball. No documentation update is required.

What is the best way to verify this PR?

Run ./pkg weasel and ensure that it continues to pass. Additionally, remove your .git directory from a clean checkout and run ./pkg to build everything. Weasel should pass.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

This version has a number of feature improvements, including the ability to tag
files directly with SPDX-License-Identifier fields so they are properly
identified even if they move and will recognize a .gitignore file even if the
directory is not a git work tree. This is important for running weasel on
released tarballs.
@rawlinp rawlinp added build related to the build process new feature A new feature, capability or behavior labels Jun 4, 2020
Copy link
Copy Markdown
Member

@ezelkow1 ezelkow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm in relation to the recent weasel changes. Tested here and had empty weasel.txt output

@dneuman64 dneuman64 self-assigned this Jun 4, 2020
@dneuman64 dneuman64 merged commit 931a620 into apache:master Jun 4, 2020
@zrhoffman zrhoffman mentioned this pull request Jun 30, 2020
6 tasks
zrhoffman pushed a commit to zrhoffman/trafficcontrol that referenced this pull request Oct 26, 2020
  This version has a number of feature improvements, including the ability to tag
  files directly with SPDX-License-Identifier fields so they are properly
  identified even if they move and will recognize a .gitignore file even if the
  directory is not a git work tree. This is important for running weasel on
  released tarballs.

  (cherry picked from commit 931a620)
rawlinp pushed a commit that referenced this pull request Oct 26, 2020
This version has a number of feature improvements, including the ability to tag
  files directly with SPDX-License-Identifier fields so they are properly
  identified even if they move and will recognize a .gitignore file even if the
  directory is not a git work tree. This is important for running weasel on
  released tarballs.

  (cherry picked from commit 931a620)

Co-authored-by: alficles <alficles@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

build related to the build process new feature A new feature, capability or behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants