This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Use cachegroupIndex to find cachegroup type, not parentIndex#4773
Merged
Conversation
rawlinp
suggested changes
Jun 10, 2020
Contributor
rawlinp
left a comment
There was a problem hiding this comment.
This looks good, but we should add some more positive test cases to the TO API tests (the example in the description would be a good one).
Member
Author
|
More positive test cases for the TO API tests added in 9709073e08, including @rob05c's. |
9709073 to
a5ddbc8
Compare
rawlinp
approved these changes
Jun 11, 2020
Contributor
rawlinp
left a comment
There was a problem hiding this comment.
TO unit tests and API tests pass, new positive test cases look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make Rob's cachegroups, POST his topology, and make sure it succeeds:
{ "name": "Foo", "description": "bar", "nodes": [ { "cachegroup": "mid-west", "parent": "", "secParent": "", "parents": [] }, { "cachegroup": "sacramento-ca-usa", "parent": "mid-west", "secParent": "mid-east", "parents": [ 0, 2 ] }, { "cachegroup": "mid-east", "parent": "", "secParent": "", "parents": [] }, { "cachegroup": "albany-ny-usa", "parent": "mid-east", "secParent": "mid-west", "parents": [ 2, 0 ] }, { "cachegroup": "tallahassee-fl-usa", "parent": "mid-east", "secParent": "mid-west", "parents": [ 2, 0 ] } ] }If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information