Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Removes the ability to view server config files in TP as they are no longer reliable#4775

Merged
rawlinp merged 3 commits into
apache:masterfrom
mitchell852:removes-view-config-files
Jun 10, 2020
Merged

Removes the ability to view server config files in TP as they are no longer reliable#4775
rawlinp merged 3 commits into
apache:masterfrom
mitchell852:removes-view-config-files

Conversation

@mitchell852
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 commented Jun 10, 2020

What does this PR (Pull Request) do?

With the introduction of atstccfg, the contents of cache server config files as determined through the TO API are no longer reliable (as it really depends on the version of atstccfg running on the cache), therefore, this functionality is being removed from TP.

Users will still be able to see a list of config files applicable to a cache server but not its contents. To see the contents of a cache you will have to be on that cache and perform a command such as:

/opt/ort/atstccfg -s -n host-name \
        -P ... -U ... \
        -u "https://trafficops.domain.net/api/2.0/servers/{host-name}/configfiles/ats/remap.config"

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  • Navigate to a cache server (edge or mid). i.e. https://tp.domain.com/#!/servers/29
  • Select More -> View Config Files; verify that a list of config files is displayed
  • Verify that viewing the contents of each config file is not an option.

If this is a bug fix, what versions of Traffic Control are affected?

  • master
  • 4.1.0 (RC1)

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added the Traffic Portal v1 related to Traffic Portal version 1 label Jun 10, 2020
@mitchell852 mitchell852 marked this pull request as ready for review June 10, 2020 17:00
@mitchell852 mitchell852 force-pushed the removes-view-config-files branch from 5ed217c to ce37af2 Compare June 10, 2020 17:08
@mitchell852 mitchell852 requested a review from rawlinp June 10, 2020 18:29
@mitchell852 mitchell852 added the bug something isn't working as intended label Jun 10, 2020
Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that TP shows the list of config files for a cache but no longer provides the ability to view/download individual files.

@rawlinp rawlinp merged commit 327b10d into apache:master Jun 10, 2020
rawlinp pushed a commit to rawlinp/trafficcontrol that referenced this pull request Jun 10, 2020
…longer reliable (apache#4775)

* removes the ability to view server config files in TP as they are no longer reliable via the TO api

* adds change log entry

* moved change log entry

(cherry picked from commit 327b10d)
rawlinp added a commit that referenced this pull request Jun 10, 2020
…longer reliable (#4775) (#4782)

* removes the ability to view server config files in TP as they are no longer reliable via the TO api

* adds change log entry

* moved change log entry

(cherry picked from commit 327b10d)

Co-authored-by: Jeremy Mitchell <mitchell852@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Viewing cache server config files in TP is broken (404)

2 participants