This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Conversation
ocket8888
added
bug
shamrickus
approved these changes
Jun 15, 2020
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
LGTM
- All unit/api tests pass
- No
go fmtissues - Alerts have the proper case
- 201 is returned on success
- Non 200 success codes are not labeled failures (specifically tested with 201) in the python client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Fixes changes to the v1/v2 API which modified the
POST /serversresponse code from200 OKto201 Created, and also changes some alert messages in those versions back to their old content.Also changes the TO Python client to no longer incorrectly reject successful responses as failures.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Create servers in v1/v2 - probably using the Python client to kill two birds with one stone - and ensure that the response code is 201. Also maybe verify the alert messages, if you care - nothing should depend on those exact words, but I changed them back just because.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR