Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

fixed an issue with ipv4 whitelist being intialized for ipv6. #4816

Merged
rawlinp merged 2 commits intoapache:masterfrom
dneuman64:3661-anon-proxy-whitelist
Jun 23, 2020
Merged

fixed an issue with ipv4 whitelist being intialized for ipv6. #4816
rawlinp merged 2 commits intoapache:masterfrom
dneuman64:3661-anon-proxy-whitelist

Conversation

@dneuman64
Copy link
Contributor

@dneuman64 dneuman64 commented Jun 22, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Router

What is the best way to verify this PR?

Setup Anonymous Proxy blocking for a DS
Verify an IP is blocked
Add the IP to the whitelist
Re-test and verify the IP is allowed

If this is a bug fix, what versions of Traffic Control are affected?

All versions

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@dneuman64 dneuman64 added the Traffic Router related to Traffic Router label Jun 22, 2020
@rawlinp rawlinp added the bug something isn't working as intended label Jun 23, 2020
@mitchell852
Copy link
Member

@dneuman64 - can you add a changelog.md entry under the unreleased / Fixed section?

@dneuman64
Copy link
Contributor Author

hmm, I thought I did. Maybe I didn't commit

@dneuman64
Copy link
Contributor Author

There we go, forgot to push. Done @mitchell852

Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rawlinp rawlinp merged commit 8c45204 into apache:master Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anonymous blocking - ip4Whitelist does not work

3 participants