Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix flaky DSS TO API test (sometimes CDN doesn't match)#4818

Merged
ocket8888 merged 1 commit into
apache:masterfrom
rawlinp:fix-flakey-dss-test
Jun 23, 2020
Merged

Fix flaky DSS TO API test (sometimes CDN doesn't match)#4818
ocket8888 merged 1 commit into
apache:masterfrom
rawlinp:fix-flakey-dss-test

Conversation

@rawlinp
Copy link
Copy Markdown
Contributor

@rawlinp rawlinp commented Jun 23, 2020

What does this PR (Pull Request) do?

Fix this flaky TO API test:

TestDeliveryServiceServers: deliveryserviceservers_test.go:186: POST delivery service servers: 400 Bad Request[400] - Error requesting Traffic Ops https://trafficops.infra.ciab.test:443/api/2.0/deliveryserviceserver {"alerts":[{"text":"server and delivery service CDNs do not match","level":"error"}]}
  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • TO API tests

What is the best way to verify this PR?

Run the v1/v2/v3 TO API tests, verify they pass.

The following criteria are ALL met by this PR

  • This PR includes tests
  • no docs necessary
  • no changelog necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@rawlinp rawlinp added the tests related to tests and/or testing infrastructure label Jun 23, 2020
@ocket8888 ocket8888 self-assigned this Jun 23, 2020
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, all client/api integration tests passing

@ocket8888 ocket8888 merged commit 36c7591 into apache:master Jun 23, 2020
@rawlinp rawlinp deleted the fix-flakey-dss-test branch June 23, 2020 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tests related to tests and/or testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants