This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixed logging.yaml generation to properly add a newline after filters are emitted.#4846
Merged
rob05c merged 1 commit intoapache:masterfrom Jun 30, 2020
Merged
Conversation
… are emitted. Fixes apache#4845.
mitchell852
added
Traffic Ops ORT *DEPRECATED*
rob05c
approved these changes
Jun 30, 2020
Member
rob05c
left a comment
rob05c
left a comment
There was a problem hiding this comment.
Looks good! Code looks good. Tested, ran ORT against a production-like TO with multiple filters, observed filters have a newline before the next -mode, observed broken -mode on the same line without the fix.
mitchell852
pushed a commit
to mitchell852/trafficcontrol
that referenced
this pull request
Sep 2, 2020
… are emitted. (apache#4846) Fixes apache#4845. (cherry picked from commit fd6e0dd)
rawlinp
pushed a commit
to rawlinp/trafficcontrol
that referenced
this pull request
Nov 2, 2020
… are emitted. (apache#4846) Fixes apache#4845. (cherry picked from commit fd6e0dd)
rawlinp
added a commit
that referenced
this pull request
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4845.
What does this PR (Pull Request) do?
logging.yamlwhen filters are used. #4845Which Traffic Control components are affected by this PR?
As a bug fix, this simply aligns the code with the intention expressed in the documentation. No update is required.
What is the best way to verify this PR?
Use the reproduction steps is #4845 to verify that after the patch, the bug no longer occurs.
If this is a bug fix, what versions of Traffic Control are affected?
Not sure precisely, but this bug was almost certainly introduced with the switch to atstccfg.
The following criteria are ALL met by this PR
Additional Information