This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Remove grunt-usemin#4897
Merged
mitchell852 merged 2 commits intoapache:masterfrom Jul 22, 2020
shamrickus:tp/remove-usemin
Merged
Remove grunt-usemin#4897mitchell852 merged 2 commits intoapache:masterfrom shamrickus:tp/remove-usemin
mitchell852 merged 2 commits intoapache:masterfrom
shamrickus:tp/remove-usemin
Conversation
Member
|
@shamrickus - do you need to update package-lock.json as well? |
Member
Author
|
Yes, good point. I will update that |
Member
|
retest this please |
mitchell852
approved these changes
Jul 22, 2020
Member
mitchell852
left a comment
There was a problem hiding this comment.
rebuilt TP dependencies and TP and ran TP tests. all looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This removes the unused and unmaintained library
grunt-useminWhich Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the integration tests.
Ensure production and dev builds work, as well as CiaB.
The following criteria are ALL met by this PR
Additional Information
Diff output from running
grunt dist: