Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Remove grunt-usemin#4897

Merged
mitchell852 merged 2 commits intoapache:masterfrom
shamrickus:tp/remove-usemin
Jul 22, 2020
Merged

Remove grunt-usemin#4897
mitchell852 merged 2 commits intoapache:masterfrom
shamrickus:tp/remove-usemin

Conversation

@shamrickus
Copy link
Member

@shamrickus shamrickus commented Jul 17, 2020

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

This removes the unused and unmaintained library grunt-usemin

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Run the integration tests.
Ensure production and dev builds work, as well as CiaB.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Diff output from running grunt dist:

❯ diff -dr dist dist_master
diff --color -dr dist/public/index.html dist_master/public/index.html
34,37c34,37
<         <link rel="stylesheet" media="all" href="resources/styles/theme.css?built=1595342124350">
<         <link rel="stylesheet" media="all" href="resources/styles/loading.css?built=1595342124350">
<         <link rel="stylesheet" media="all" href="resources/styles/main.css?built=1595342124350">
<         <link rel="stylesheet" media="all" href="resources/assets/css/custom.css?built=1595342124350">
---
>         <link rel="stylesheet" media="all" href="resources/styles/theme.css?built=1595342071418">
>         <link rel="stylesheet" media="all" href="resources/styles/loading.css?built=1595342071418">
>         <link rel="stylesheet" media="all" href="resources/styles/main.css?built=1595342071418">
>         <link rel="stylesheet" media="all" href="resources/assets/css/custom.css?built=1595342071418">
51c51
<         <script src="resources/assets/js/shared-libs.js?built=1595342124350"></script>
---
>         <script src="resources/assets/js/shared-libs.js?built=1595342071418"></script>
53,54c53,54
<         <script src="resources/assets/js/app.js?built=1595342124350"></script>
<         <script src="resources/assets/js/config.js?built=1595342124350"></script>
---
>         <script src="resources/assets/js/app.js?built=1595342071418"></script>
>         <script src="resources/assets/js/config.js?built=1595342071418"></script>

@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 tech debt rework due to choosing easy/limited solution labels Jul 19, 2020
@mitchell852 mitchell852 self-assigned this Jul 20, 2020
@mitchell852
Copy link
Member

@shamrickus - do you need to update package-lock.json as well?

@shamrickus
Copy link
Member Author

Yes, good point. I will update that

@mitchell852
Copy link
Member

retest this please

Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebuilt TP dependencies and TP and ran TP tests. all looks good.

@mitchell852 mitchell852 merged commit f395fa0 into apache:master Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants